From 12277bc90d2140905d64ba339b52b2259f2e6326 Mon Sep 17 00:00:00 2001
From: Willem Jan Palenstijn <Willem.Jan.Palenstijn@cwi.nl>
Date: Mon, 16 Oct 2017 21:53:31 +0200
Subject: Update miniconda release for linux conda builds

---
 python/conda/linux_release/buildenv/Dockerfile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'python')

diff --git a/python/conda/linux_release/buildenv/Dockerfile b/python/conda/linux_release/buildenv/Dockerfile
index c73e4b9..ce0b63b 100644
--- a/python/conda/linux_release/buildenv/Dockerfile
+++ b/python/conda/linux_release/buildenv/Dockerfile
@@ -3,11 +3,11 @@ ENV PATH /root/miniconda3/bin:$PATH
 ENV DEBIAN_FRONTEND noninteractive
 # http://developer.download.nvidia.com/compute/cuda/5_5/rel/installers/cuda_5.5.22_linux_64.run
 ADD cuda_5.5.22_linux_64.run /root/
-# https://repo.continuum.io/miniconda/Miniconda3-4.2.12-Linux-x86_64.sh
-ADD Miniconda3-4.2.12-Linux-x86_64.sh /root/
+# https://repo.continuum.io/miniconda/Miniconda3-4.3.27.1-Linux-x86_64.sh
+ADD Miniconda3-4.3.27.1-Linux-x86_64.sh /root/
 RUN apt-get update
 RUN apt-get install -y perl-modules build-essential autoconf libtool automake libboost-dev git
-RUN /bin/bash /root/Miniconda3-4.2.12-Linux-x86_64.sh -b
+RUN /bin/bash /root/Miniconda3-4.3.27.1-Linux-x86_64.sh -b
 RUN /bin/bash /root/cuda_5.5.22_linux_64.run -toolkit -silent
 RUN conda install -y conda-build
 ENV CUDA_ROOT /usr/local/cuda
-- 
cgit v1.2.3


From c0cfd8f5d9a8f53246fc4120345687b32e4a23cf Mon Sep 17 00:00:00 2001
From: Willem Jan Palenstijn <Willem.Jan.Palenstijn@cwi.nl>
Date: Mon, 16 Oct 2017 22:33:58 +0200
Subject: Update miniconda release for linux conda builds

---
 python/conda/linux_release/release.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'python')

diff --git a/python/conda/linux_release/release.sh b/python/conda/linux_release/release.sh
index cf62bd5..089cc7c 100644
--- a/python/conda/linux_release/release.sh
+++ b/python/conda/linux_release/release.sh
@@ -3,7 +3,7 @@
 D=`mktemp -d`
 
 [ -f buildenv/cuda_5.5.22_linux_64.run ] || (cd buildenv; wget http://developer.download.nvidia.com/compute/cuda/5_5/rel/installers/cuda_5.5.22_linux_64.run )
-[ -f buildenv/Miniconda3-4.2.12-Linux-x86_64.sh ] || (cd buildenv; wget https://repo.continuum.io/miniconda/Miniconda3-4.2.12-Linux-x86_64.sh )
+[ -f buildenv/Miniconda3-4.3.27.1-Linux-x86_64.sh ] || (cd buildenv; wget https://repo.continuum.io/miniconda/Miniconda3-4.3.27.1-Linux-x86_64.sh )
 
 docker build -t astra-build-env buildenv
 #docker build --no-cache --build-arg=BUILD_NUMBER=0 -t astra-builder builder
-- 
cgit v1.2.3


From a02ee2a02aead0c69acfd15693fd12d0d5efd52f Mon Sep 17 00:00:00 2001
From: Allard Hendriksen <Allard.Hendriksen@cwi.nl>
Date: Wed, 11 Oct 2017 16:41:31 +0200
Subject: Improve python create_vol_geom

Remove redundant window computations. Also fixes the problem where

>> astra.create_vol_geom(10,10,10)

would not set the window options while all other parameter
configurations of create_vol_geom did set the window options.

Respects custom arguments for the window.
---
 python/astra/creators.py | 29 +++++++++++------------------
 1 file changed, 11 insertions(+), 18 deletions(-)

(limited to 'python')

diff --git a/python/astra/creators.py b/python/astra/creators.py
index 53d98e0..1e4d937 100644
--- a/python/astra/creators.py
+++ b/python/astra/creators.py
@@ -81,37 +81,19 @@ This method can be called in a number of ways:
     if len(varargin) == 1 and isinstance(varargin[0], int) == 1:
         vol_geom['GridRowCount'] = varargin[0]
         vol_geom['GridColCount'] = varargin[0]
-        vol_geom['option']['WindowMinX'] = -varargin[0] / 2.
-        vol_geom['option']['WindowMaxX'] = varargin[0] / 2.
-        vol_geom['option']['WindowMinY'] = -varargin[0] / 2.
-        vol_geom['option']['WindowMaxY'] = varargin[0] / 2.
     # astra_create_vol_geom([row_count col_count])
     elif len(varargin) == 1 and len(varargin[0]) == 2:
         vol_geom['GridRowCount'] = varargin[0][0]
         vol_geom['GridColCount'] = varargin[0][1]
-        vol_geom['option']['WindowMinX'] = -varargin[0][1] / 2.
-        vol_geom['option']['WindowMaxX'] = varargin[0][1] / 2.
-        vol_geom['option']['WindowMinY'] = -varargin[0][0] / 2.
-        vol_geom['option']['WindowMaxY'] = varargin[0][0] / 2.
     # astra_create_vol_geom([row_count col_count slice_count])
     elif len(varargin) == 1 and len(varargin[0]) == 3:
         vol_geom['GridRowCount'] = varargin[0][0]
         vol_geom['GridColCount'] = varargin[0][1]
         vol_geom['GridSliceCount'] = varargin[0][2]
-        vol_geom['option']['WindowMinX'] = -varargin[0][1] / 2.
-        vol_geom['option']['WindowMaxX'] = varargin[0][1] / 2.
-        vol_geom['option']['WindowMinY'] = -varargin[0][0] / 2.
-        vol_geom['option']['WindowMaxY'] = varargin[0][0] / 2.
-        vol_geom['option']['WindowMinZ'] = -varargin[0][2] / 2.
-        vol_geom['option']['WindowMaxZ'] = varargin[0][2] / 2.
     # astra_create_vol_geom(row_count, col_count)
     elif len(varargin) == 2:
         vol_geom['GridRowCount'] = varargin[0]
         vol_geom['GridColCount'] = varargin[1]
-        vol_geom['option']['WindowMinX'] = -varargin[1] / 2.
-        vol_geom['option']['WindowMaxX'] = varargin[1] / 2.
-        vol_geom['option']['WindowMinY'] = -varargin[0] / 2.
-        vol_geom['option']['WindowMaxY'] = varargin[0] / 2.
     # astra_create_vol_geom(row_count, col_count, min_x, max_x, min_y, max_y)
     elif len(varargin) == 6:
         vol_geom['GridRowCount'] = varargin[0]
@@ -136,6 +118,17 @@ This method can be called in a number of ways:
         vol_geom['option']['WindowMaxY'] = varargin[6]
         vol_geom['option']['WindowMinZ'] = varargin[7]
         vol_geom['option']['WindowMaxZ'] = varargin[8]
+
+    # set the window options, if not set already.
+    if not 'WindowMinX' in vol_geom['option']:
+        vol_geom['option']['WindowMinX'] = -vol_geom['GridColCount'] / 2.
+        vol_geom['option']['WindowMaxX'] =  vol_geom['GridColCount'] / 2.
+        vol_geom['option']['WindowMinY'] = -vol_geom['GridRowCount'] / 2.
+        vol_geom['option']['WindowMaxY'] =  vol_geom['GridRowCount'] / 2.
+        if 'GridSliceCount' in vol_geom:
+            vol_geom['option']['WindowMinZ'] = -vol_geom['GridSliceCount'] / 2.
+            vol_geom['option']['WindowMaxZ'] =  vol_geom['GridSliceCount'] / 2.
+
     return vol_geom
 
 
-- 
cgit v1.2.3


From 17ebcfefa7c42cff61a81bf12a915983b330ed15 Mon Sep 17 00:00:00 2001
From: Willem Jan Palenstijn <wjp@usecode.org>
Date: Tue, 17 Oct 2017 17:20:40 +0200
Subject: Add astra.astra.get_gpu_info utility function

---
 cuda/2d/util.cu          | 24 ++++++++++++++++++++++++
 cuda/2d/util.h           |  4 ++++
 python/astra/astra.py    | 10 ++++++++++
 python/astra/astra_c.pyx |  9 +++++++++
 4 files changed, 47 insertions(+)

(limited to 'python')

diff --git a/cuda/2d/util.cu b/cuda/2d/util.cu
index 09d1a2b..9c1bb28 100644
--- a/cuda/2d/util.cu
+++ b/cuda/2d/util.cu
@@ -274,5 +274,29 @@ void reportCudaError(cudaError_t err)
 }
 
 
+_AstraExport std::string getCudaDeviceString(int device)
+{
+	char buf[1024];
+	cudaError_t err;
+	if (device == -1) {
+		err = cudaGetDevice(&device);
+		if (err != cudaSuccess) {
+			return "Error getting current GPU index";
+		}
+	}
+
+	cudaDeviceProp prop;
+	err = cudaGetDeviceProperties(&prop, device);
+	if (err != cudaSuccess) {
+		snprintf(buf, 1024, "GPU #%d: Invalid device (%d): %s", device, err, cudaGetErrorString(err));
+		return buf;
+	}
+
+	long mem = prop.totalGlobalMem / (1024*1024);
+	snprintf(buf, 1024, "GPU #%d: %s, with %ldMB", device, prop.name, mem);
+	return buf;
+}
+
+
 
 }
diff --git a/cuda/2d/util.h b/cuda/2d/util.h
index 875aae3..31fcfbd 100644
--- a/cuda/2d/util.h
+++ b/cuda/2d/util.h
@@ -30,6 +30,7 @@ along with the ASTRA Toolbox. If not, see <http://www.gnu.org/licenses/>.
 
 #include <cuda.h>
 #include <driver_types.h>
+#include <string>
 
 #ifdef _MSC_VER
 
@@ -92,6 +93,9 @@ void reportCudaError(cudaError_t err);
 float dotProduct2D(float* D_data, unsigned int pitch,
                    unsigned int width, unsigned int height);
 
+// Return string with CUDA device number, name and memory size.
+// Use device == -1 to get info for the current device.
+_AstraExport std::string getCudaDeviceString(int device);
 
 }
 
diff --git a/python/astra/astra.py b/python/astra/astra.py
index 3804d51..434ccb9 100644
--- a/python/astra/astra.py
+++ b/python/astra/astra.py
@@ -45,6 +45,16 @@ def set_gpu_index(idx, memory=0):
     """
     a.set_gpu_index(idx, memory)
 
+def get_gpu_info(idx=-1):
+    """Get GPU info.
+    
+    :param idx: GPU index, or -1 for current device
+    :type idx: :class:`int`
+    :returns: :class:`str` -- GPU info
+    """
+    return a.get_gpu_info(idx)
+
+
 def delete(ids):
     """Delete an astra object.
     
diff --git a/python/astra/astra_c.pyx b/python/astra/astra_c.pyx
index 6de10da..f39b0a1 100644
--- a/python/astra/astra_c.pyx
+++ b/python/astra/astra_c.pyx
@@ -42,9 +42,14 @@ cdef extern from "astra/Globals.h" namespace "astra":
 IF HAVE_CUDA==True:
   cdef extern from "../cuda/2d/darthelper.h" namespace "astraCUDA":
       bool setGPUIndex(int)
+  cdef extern from "../cuda/2d/util.h" namespace "astraCUDA":
+      string getCudaDeviceString(int)
 ELSE:
   def setGPUIndex():
     pass
+  def getCudaDeviceString(idx):
+    pass
+
 cdef extern from "astra/CompositeGeometryManager.h" namespace "astra":
     cdef cppclass SGPUParams:
         vector[int] GPUIndices
@@ -85,9 +90,13 @@ IF HAVE_CUDA==True:
         ret = setGPUIndex(params.GPUIndices[0])
         if not ret:
             six.print_("Failed to set GPU " + str(params.GPUIndices[0]))
+  def get_gpu_info(idx=-1):
+    return wrap_from_bytes(getCudaDeviceString(idx))
 ELSE:
   def set_gpu_index(idx, memory=0):
     raise NotImplementedError("CUDA support is not enabled in ASTRA")
+  def get_gpu_info(idx=-1):
+    raise NotImplementedError("CUDA support is not enabled in ASTRA")
 
 def delete(ids):
     import collections
-- 
cgit v1.2.3


From 8d8a3d26372d9c0a784e181121fc2b360f6fee51 Mon Sep 17 00:00:00 2001
From: Willem Jan Palenstijn <Willem.Jan.Palenstijn@cwi.nl>
Date: Thu, 31 Aug 2017 16:47:29 +0200
Subject: Add trailing ,/; to string repr of float vector/matrix

This makes it possible to differentiate between a scalar and a one-element
vector, and fixes #111.
---
 python/astra/utils.pyx | 2 ++
 src/Utilities.cpp      | 9 ++++++---
 src/XMLNode.cpp        | 9 ++++-----
 3 files changed, 12 insertions(+), 8 deletions(-)

(limited to 'python')

diff --git a/python/astra/utils.pyx b/python/astra/utils.pyx
index a40916b..bcff6c3 100644
--- a/python/astra/utils.pyx
+++ b/python/astra/utils.pyx
@@ -171,6 +171,7 @@ def stringToPythonValue(inputIn):
     input = castString(inputIn)
     # matrix
     if ';' in input:
+        input = input.rstrip(';')
         row_strings = input.split(';')
         col_strings = row_strings[0].split(',')
         nRows = len(row_strings)
@@ -185,6 +186,7 @@ def stringToPythonValue(inputIn):
 
     # vector
     if ',' in input:
+        input = input.rstrip(',')
         items = input.split(',')
         out = np.empty(len(items))
         for idx,item in enumerate(items):
diff --git a/src/Utilities.cpp b/src/Utilities.cpp
index eb34092..c90e67b 100644
--- a/src/Utilities.cpp
+++ b/src/Utilities.cpp
@@ -77,6 +77,7 @@ std::vector<double> stringToDoubleVector(const std::string &s)
 	out.reserve(100);
 	std::istringstream iss;
 	iss.imbue(std::locale::classic());
+	size_t length = s.size();
 	size_t current = 0;
 	size_t next;
 	do {
@@ -88,7 +89,7 @@ std::vector<double> stringToDoubleVector(const std::string &s)
 		iss >> f;
 		out.push_back(f);
 		current = next + 1;
-	} while (next != std::string::npos);
+	} while (next != std::string::npos && current != length);
 
 	return out;
 }
@@ -97,6 +98,7 @@ template<typename T>
 std::vector<T> stringToVector(const std::string& s)
 {
 	std::vector<T> out;
+	size_t length = s.size();
 	size_t current = 0;
 	size_t next;
 	do {
@@ -104,7 +106,7 @@ std::vector<T> stringToVector(const std::string& s)
 		std::string t = s.substr(current, next - current);
 		out.push_back(stringTo<T>(t));
 		current = next + 1;
-	} while (next != std::string::npos);
+	} while (next != std::string::npos && current != length);
 
 	return out;
 }
@@ -134,13 +136,14 @@ void splitString(std::vector<std::string> &items, const std::string& s,
                  const char *delim)
 {
 	items.clear();
+	size_t length = s.size();
 	size_t current = 0;
 	size_t next;
 	do {
 		next = s.find_first_of(delim, current);
 		items.push_back(s.substr(current, next - current));
 		current = next + 1;
-	} while (next != std::string::npos);
+	} while (next != std::string::npos && current != length);
 }
 
 }
diff --git a/src/XMLNode.cpp b/src/XMLNode.cpp
index 0ddc511..2bf1330 100644
--- a/src/XMLNode.cpp
+++ b/src/XMLNode.cpp
@@ -379,9 +379,9 @@ void XMLNode::setContent(float32 _fValue)
 
 template<typename T>
 static std::string setContentList_internal(T* pfList, int _iSize) {
-	std::string str = (_iSize > 0) ? StringUtil::toString(pfList[0]) : "";
-	for (int i = 1; i < _iSize; i++) {
-		str += "," + StringUtil::toString(pfList[i]);
+	std::string str;
+	for (int i = 0; i < _iSize; i++) {
+		str += StringUtil::toString(pfList[i]) + ",";
 	}
 	return str;
 }
@@ -422,8 +422,7 @@ static std::string setContentMatrix_internal(T* _pfMatrix, int _iWidth, int _iHe
 		for (int x = 1; x < _iWidth; x++)
 			s << "," << _pfMatrix[x*s1 + y*s2];
 
-		if (y != _iHeight-1)
-			s << ";";
+		s << ";";
 	}
 
 	return s.str();
-- 
cgit v1.2.3


From 71d27819b1b046109b5c70e3bd112f436e96a545 Mon Sep 17 00:00:00 2001
From: Willem Jan Palenstijn <Willem.Jan.Palenstijn@cwi.nl>
Date: Mon, 23 Oct 2017 12:14:28 +0200
Subject: Support 2d/3d in astra.algorithm.get_res_norm

---
 python/astra/PyIncludes.pxd  |  4 ++++
 python/astra/algorithm_c.pyx | 17 ++++++++++++-----
 2 files changed, 16 insertions(+), 5 deletions(-)

(limited to 'python')

diff --git a/python/astra/PyIncludes.pxd b/python/astra/PyIncludes.pxd
index c091963..512b82f 100644
--- a/python/astra/PyIncludes.pxd
+++ b/python/astra/PyIncludes.pxd
@@ -152,6 +152,10 @@ cdef extern from "astra/ReconstructionAlgorithm2D.h" namespace "astra":
     cdef cppclass CReconstructionAlgorithm2D:
         bool getResidualNorm(float32&)
 
+cdef extern from "astra/ReconstructionAlgorithm3D.h" namespace "astra":
+    cdef cppclass CReconstructionAlgorithm3D:
+        bool getResidualNorm(float32&)
+
 cdef extern from "astra/Projector2D.h" namespace "astra":
     cdef cppclass CProjector2D:
         bool isInitialized()
diff --git a/python/astra/algorithm_c.pyx b/python/astra/algorithm_c.pyx
index 9ed0634..161fe98 100644
--- a/python/astra/algorithm_c.pyx
+++ b/python/astra/algorithm_c.pyx
@@ -44,7 +44,8 @@ from .utils import wrap_from_bytes
 cdef CAlgorithmManager * manAlg = <CAlgorithmManager * >PyAlgorithmManager.getSingletonPtr()
 
 cdef extern from *:
-    CReconstructionAlgorithm2D * dynamic_cast_recAlg "dynamic_cast<astra::CReconstructionAlgorithm2D*>" (CAlgorithm * ) except NULL
+    CReconstructionAlgorithm2D * dynamic_cast_recAlg2D "dynamic_cast<astra::CReconstructionAlgorithm2D*>" (CAlgorithm * )
+    CReconstructionAlgorithm3D * dynamic_cast_recAlg3D "dynamic_cast<astra::CReconstructionAlgorithm3D*>" (CAlgorithm * )
 
 
 def create(config):
@@ -79,12 +80,18 @@ def run(i, iterations=0):
 
 def get_res_norm(i):
     cdef CReconstructionAlgorithm2D * pAlg2D
+    cdef CReconstructionAlgorithm3D * pAlg3D
     cdef CAlgorithm * alg = getAlg(i)
     cdef float32 res = 0.0
-    pAlg2D = dynamic_cast_recAlg(alg)
-    if pAlg2D == NULL:
-        raise Exception("Operation not supported.")
-    if not pAlg2D.getResidualNorm(res):
+    pAlg2D = dynamic_cast_recAlg2D(alg)
+    pAlg3D = dynamic_cast_recAlg3D(alg)
+    if pAlg2D != NULL:
+        if not pAlg2D.getResidualNorm(res):
+            raise Exception("Operation not supported.")
+    elif pAlg3D != NULL:
+        if not pAlg3D.getResidualNorm(res):
+            raise Exception("Operation not supported.")
+    else:
         raise Exception("Operation not supported.")
     return res
 
-- 
cgit v1.2.3


From 42b5e731a9ac6c3aa4751cee2c09758d58d18427 Mon Sep 17 00:00:00 2001
From: Willem Jan Palenstijn <Willem.Jan.Palenstijn@cwi.nl>
Date: Mon, 23 Oct 2017 13:57:03 +0200
Subject: Fix usage of cython except

---
 python/astra/experimental.pyx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'python')

diff --git a/python/astra/experimental.pyx b/python/astra/experimental.pyx
index 0af3118..136165b 100644
--- a/python/astra/experimental.pyx
+++ b/python/astra/experimental.pyx
@@ -40,8 +40,8 @@ IF HAVE_CUDA==True:
             bool doBP(CProjector3D *, vector[CFloat32VolumeData3D *], vector[CFloat32ProjectionData3D *])
 
     cdef extern from *:
-        CFloat32VolumeData3D * dynamic_cast_vol_mem "dynamic_cast<astra::CFloat32VolumeData3D*>" (CFloat32Data3D * ) except NULL
-        CFloat32ProjectionData3D * dynamic_cast_proj_mem "dynamic_cast<astra::CFloat32ProjectionData3D*>" (CFloat32Data3D * ) except NULL
+        CFloat32VolumeData3D * dynamic_cast_vol_mem "dynamic_cast<astra::CFloat32VolumeData3D*>" (CFloat32Data3D * )
+        CFloat32ProjectionData3D * dynamic_cast_proj_mem "dynamic_cast<astra::CFloat32ProjectionData3D*>" (CFloat32Data3D * )
 
     cdef extern from "astra/Float32ProjectionData3D.h" namespace "astra":
         cdef cppclass CFloat32ProjectionData3D:
-- 
cgit v1.2.3


From 642977e9d613d673fbf46e11cb92b6785fe02cc6 Mon Sep 17 00:00:00 2001
From: Willem Jan Palenstijn <Willem.Jan.Palenstijn@cwi.nl>
Date: Thu, 26 Oct 2017 11:01:36 +0200
Subject: Fix usage of cython except

---
 python/astra/data3d_c.pyx | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

(limited to 'python')

diff --git a/python/astra/data3d_c.pyx b/python/astra/data3d_c.pyx
index 78ed620..0717ca0 100644
--- a/python/astra/data3d_c.pyx
+++ b/python/astra/data3d_c.pyx
@@ -60,7 +60,13 @@ cdef extern from "Python.h":
 cdef CData3DManager * man3d = <CData3DManager * >PyData3DManager.getSingletonPtr()
 
 cdef extern from *:
-    CFloat32Data3DMemory * dynamic_cast_mem "dynamic_cast<astra::CFloat32Data3DMemory*>" (CFloat32Data3D * ) except NULL
+    CFloat32Data3DMemory * dynamic_cast_mem "dynamic_cast<astra::CFloat32Data3DMemory*>" (CFloat32Data3D * )
+
+cdef CFloat32Data3DMemory * dynamic_cast_mem_safe(CFloat32Data3D *obj) except NULL:
+    cdef CFloat32Data3DMemory *ret = dynamic_cast_mem(obj)
+    if not ret:
+        raise RuntimeError("Not a memory 3D data object")
+    return ret
 
 cdef extern from "CFloat32CustomPython.h":
     cdef cppclass CFloat32CustomPython:
@@ -154,12 +160,12 @@ def create(datatype,geometry,data=None, link=False):
         raise RuntimeError("Couldn't initialize data object.")
 
     if not link:
-        fillDataObject(dynamic_cast_mem(pDataObject3D), data)
+        fillDataObject(dynamic_cast_mem_safe(pDataObject3D), data)
 
     return man3d.store(<CFloat32Data3D*>pDataObject3D)
 
 def get_geometry(i):
-    cdef CFloat32Data3DMemory * pDataObject = dynamic_cast_mem(getObject(i))
+    cdef CFloat32Data3DMemory * pDataObject = dynamic_cast_mem_safe(getObject(i))
     cdef CFloat32ProjectionData3DMemory * pDataObject2
     cdef CFloat32VolumeData3DMemory * pDataObject3
     if pDataObject.getType() == THREEPROJECTION:
@@ -173,7 +179,7 @@ def get_geometry(i):
     return geom
 
 def change_geometry(i, geom):
-    cdef CFloat32Data3DMemory * pDataObject = dynamic_cast_mem(getObject(i))
+    cdef CFloat32Data3DMemory * pDataObject = dynamic_cast_mem_safe(getObject(i))
     cdef CFloat32ProjectionData3DMemory * pDataObject2
     cdef CFloat32VolumeData3DMemory * pDataObject3
     if pDataObject.getType() == THREEPROJECTION:
@@ -262,7 +268,7 @@ cdef CFloat32Data3D * getObject(i) except NULL:
 @cython.boundscheck(False)
 @cython.wraparound(False)
 def get(i):
-    cdef CFloat32Data3DMemory * pDataObject = dynamic_cast_mem(getObject(i))
+    cdef CFloat32Data3DMemory * pDataObject = dynamic_cast_mem_safe(getObject(i))
     outArr = np.empty((pDataObject.getDepth(),pDataObject.getHeight(), pDataObject.getWidth()),dtype=np.float32,order='C')
     cdef float [:,:,::1] mView = outArr
     cdef float [:,:,::1] cView = <float[:outArr.shape[0],:outArr.shape[1],:outArr.shape[2]]> pDataObject.getData3D()[0][0]
@@ -270,7 +276,7 @@ def get(i):
     return outArr
 
 def get_shared(i):
-    cdef CFloat32Data3DMemory * pDataObject = dynamic_cast_mem(getObject(i))
+    cdef CFloat32Data3DMemory * pDataObject = dynamic_cast_mem_safe(getObject(i))
     outArr = np.empty((pDataObject.getDepth(),pDataObject.getHeight(), pDataObject.getWidth()),dtype=np.float32,order='C')
     cdef np.npy_intp shape[3]
     shape[0] = <np.npy_intp> pDataObject.getDepth()
@@ -283,7 +289,7 @@ def get_single(i):
 
 def store(i,data):
     cdef CFloat32Data3D * pDataObject = getObject(i)
-    fillDataObject(dynamic_cast_mem(pDataObject), data)
+    fillDataObject(dynamic_cast_mem_safe(pDataObject), data)
 
 def dimensions(i):
     cdef CFloat32Data3D * pDataObject = getObject(i)
-- 
cgit v1.2.3


From f70f68fcd465f421b566b199e23e66c1f186b01d Mon Sep 17 00:00:00 2001
From: Willem Jan Palenstijn <Willem.Jan.Palenstijn@cwi.nl>
Date: Wed, 1 Nov 2017 15:05:13 +0100
Subject: Separate cuda from astra headers further

---
 cuda/2d/astra.cu                   | 41 ++++++++++++++++++++++++++++++++++++++
 cuda/2d/astra.h                    |  9 +++++++++
 cuda/2d/darthelper.cu              | 16 ---------------
 cuda/2d/darthelper.h               |  2 --
 cuda/2d/util.cu                    | 25 -----------------------
 cuda/2d/util.h                     |  4 ----
 python/astra/astra_c.pyx           |  3 +--
 src/CudaDartMaskAlgorithm.cpp      |  1 +
 src/CudaDartSmoothingAlgorithm.cpp |  1 +
 src/CudaDataOperationAlgorithm.cpp |  1 +
 src/CudaRoiSelectAlgorithm.cpp     |  1 +
 11 files changed, 55 insertions(+), 49 deletions(-)

(limited to 'python')

diff --git a/cuda/2d/astra.cu b/cuda/2d/astra.cu
index 2ff9230..c0132b2 100644
--- a/cuda/2d/astra.cu
+++ b/cuda/2d/astra.cu
@@ -986,6 +986,47 @@ bool convertAstraGeometry(const CVolumeGeometry2D* pVolGeom,
 }
 
 
+}
+
+namespace astraCUDA {
+
+
+_AstraExport std::string getCudaDeviceString(int device)
+{
+	char buf[1024];
+	cudaError_t err;
+	if (device == -1) {
+		err = cudaGetDevice(&device);
+		if (err != cudaSuccess) {
+			return "Error getting current GPU index";
+		}
+	}
+
+	cudaDeviceProp prop;
+	err = cudaGetDeviceProperties(&prop, device);
+	if (err != cudaSuccess) {
+		snprintf(buf, 1024, "GPU #%d: Invalid device (%d): %s", device, err, cudaGetErrorString(err));
+		return buf;
+	}
+
+	long mem = prop.totalGlobalMem / (1024*1024);
+	snprintf(buf, 1024, "GPU #%d: %s, with %ldMB", device, prop.name, mem);
+	return buf;
+}
+
+_AstraExport bool setGPUIndex(int iGPUIndex)
+{
+        if (iGPUIndex != -1) {
+                cudaSetDevice(iGPUIndex);
+                cudaError_t err = cudaGetLastError();
+
+                // Ignore errors caused by calling cudaSetDevice multiple times
+                if (err != cudaSuccess && err != cudaErrorSetOnActiveProcess)
+                        return false;
+        }
+
+        return true;
+}
 
 
 }
diff --git a/cuda/2d/astra.h b/cuda/2d/astra.h
index c9e0762..e4cefac 100644
--- a/cuda/2d/astra.h
+++ b/cuda/2d/astra.h
@@ -224,6 +224,15 @@ _AstraExport bool convertAstraGeometry(const CVolumeGeometry2D* pVolGeom,
                     astraCUDA::SFanProjection*& pProjs,
                     float& outputScale);
 
+}
+
+namespace astraCUDA {
+
+// Return string with CUDA device number, name and memory size.
+// Use device == -1 to get info for the current device.
+_AstraExport std::string getCudaDeviceString(int device);
+
+_AstraExport bool setGPUIndex(int index);
 
 }
 #endif
diff --git a/cuda/2d/darthelper.cu b/cuda/2d/darthelper.cu
index 744184e..d4b5220 100644
--- a/cuda/2d/darthelper.cu
+++ b/cuda/2d/darthelper.cu
@@ -356,20 +356,4 @@ void dartSmoothing(float* out, const float* in, float b, unsigned int radius, un
 }
 
 
-
-_AstraExport bool setGPUIndex(int iGPUIndex)
-{
-	if (iGPUIndex != -1) {
-		cudaSetDevice(iGPUIndex);
-		cudaError_t err = cudaGetLastError();
-
-		// Ignore errors caused by calling cudaSetDevice multiple times
-		if (err != cudaSuccess && err != cudaErrorSetOnActiveProcess)
-			return false;
-	}
-
-	return true;
-}
-
-
 }
diff --git a/cuda/2d/darthelper.h b/cuda/2d/darthelper.h
index 9a2837c..67a6a7d 100644
--- a/cuda/2d/darthelper.h
+++ b/cuda/2d/darthelper.h
@@ -36,8 +36,6 @@ namespace astraCUDA {
 	void dartMask(float* out, const float* in, unsigned int conn, unsigned int radius, unsigned int threshold, unsigned int width, unsigned int height);
 	void dartSmoothing(float* out, const float* in, float b, unsigned int radius, unsigned int width, unsigned int height);
 
-	_AstraExport bool setGPUIndex(int index);
-
 }
 
 #endif
diff --git a/cuda/2d/util.cu b/cuda/2d/util.cu
index 9c1bb28..871e139 100644
--- a/cuda/2d/util.cu
+++ b/cuda/2d/util.cu
@@ -274,29 +274,4 @@ void reportCudaError(cudaError_t err)
 }
 
 
-_AstraExport std::string getCudaDeviceString(int device)
-{
-	char buf[1024];
-	cudaError_t err;
-	if (device == -1) {
-		err = cudaGetDevice(&device);
-		if (err != cudaSuccess) {
-			return "Error getting current GPU index";
-		}
-	}
-
-	cudaDeviceProp prop;
-	err = cudaGetDeviceProperties(&prop, device);
-	if (err != cudaSuccess) {
-		snprintf(buf, 1024, "GPU #%d: Invalid device (%d): %s", device, err, cudaGetErrorString(err));
-		return buf;
-	}
-
-	long mem = prop.totalGlobalMem / (1024*1024);
-	snprintf(buf, 1024, "GPU #%d: %s, with %ldMB", device, prop.name, mem);
-	return buf;
-}
-
-
-
 }
diff --git a/cuda/2d/util.h b/cuda/2d/util.h
index 6e36b6e..382d862 100644
--- a/cuda/2d/util.h
+++ b/cuda/2d/util.h
@@ -79,10 +79,6 @@ void reportCudaError(cudaError_t err);
 float dotProduct2D(float* D_data, unsigned int pitch,
                    unsigned int width, unsigned int height);
 
-// Return string with CUDA device number, name and memory size.
-// Use device == -1 to get info for the current device.
-_AstraExport std::string getCudaDeviceString(int device);
-
 }
 
 #endif
diff --git a/python/astra/astra_c.pyx b/python/astra/astra_c.pyx
index f39b0a1..f25fc2a 100644
--- a/python/astra/astra_c.pyx
+++ b/python/astra/astra_c.pyx
@@ -40,9 +40,8 @@ cdef extern from "astra/Globals.h" namespace "astra":
     bool cudaEnabled()
 
 IF HAVE_CUDA==True:
-  cdef extern from "../cuda/2d/darthelper.h" namespace "astraCUDA":
+  cdef extern from "../cuda/2d/astra.h" namespace "astraCUDA":
       bool setGPUIndex(int)
-  cdef extern from "../cuda/2d/util.h" namespace "astraCUDA":
       string getCudaDeviceString(int)
 ELSE:
   def setGPUIndex():
diff --git a/src/CudaDartMaskAlgorithm.cpp b/src/CudaDartMaskAlgorithm.cpp
index 375d565..a2e1ee6 100644
--- a/src/CudaDartMaskAlgorithm.cpp
+++ b/src/CudaDartMaskAlgorithm.cpp
@@ -29,6 +29,7 @@ along with the ASTRA Toolbox. If not, see <http://www.gnu.org/licenses/>.
 
 #include "astra/CudaDartMaskAlgorithm.h"
 
+#include "../cuda/2d/astra.h"
 #include "../cuda/2d/darthelper.h"
 #include "../cuda/2d/algo.h"
 
diff --git a/src/CudaDartSmoothingAlgorithm.cpp b/src/CudaDartSmoothingAlgorithm.cpp
index 0759ea0..9e586c0 100644
--- a/src/CudaDartSmoothingAlgorithm.cpp
+++ b/src/CudaDartSmoothingAlgorithm.cpp
@@ -29,6 +29,7 @@ along with the ASTRA Toolbox. If not, see <http://www.gnu.org/licenses/>.
 
 #include "astra/CudaDartSmoothingAlgorithm.h"
 
+#include "../cuda/2d/astra.h"
 #include "../cuda/2d/darthelper.h"
 #include "../cuda/2d/algo.h"
 
diff --git a/src/CudaDataOperationAlgorithm.cpp b/src/CudaDataOperationAlgorithm.cpp
index f9466e2..6c6b27c 100644
--- a/src/CudaDataOperationAlgorithm.cpp
+++ b/src/CudaDataOperationAlgorithm.cpp
@@ -31,6 +31,7 @@ along with the ASTRA Toolbox. If not, see <http://www.gnu.org/licenses/>.
 
 #include "../cuda/2d/algo.h"
 #include "../cuda/2d/darthelper.h"
+#include "../cuda/2d/astra.h"
 #include "../cuda/2d/arith.h"
 
 #include "astra/AstraObjectManager.h"
diff --git a/src/CudaRoiSelectAlgorithm.cpp b/src/CudaRoiSelectAlgorithm.cpp
index baf8a6f..2b0ba15 100644
--- a/src/CudaRoiSelectAlgorithm.cpp
+++ b/src/CudaRoiSelectAlgorithm.cpp
@@ -29,6 +29,7 @@ along with the ASTRA Toolbox. If not, see <http://www.gnu.org/licenses/>.
 
 #include "astra/CudaRoiSelectAlgorithm.h"
 
+#include "../cuda/2d/astra.h"
 #include "../cuda/2d/darthelper.h"
 #include "../cuda/2d/algo.h"
 
-- 
cgit v1.2.3


From 355ee14464f76f7a506143ef44a9b5a5319c4951 Mon Sep 17 00:00:00 2001
From: Willem Jan Palenstijn <wjp@usecode.org>
Date: Tue, 17 Oct 2017 21:06:50 +0200
Subject: Move set_gpu_index, get_gpu_info from astra.astra to astra

---
 python/astra/__init__.py           | 3 ++-
 samples/python/s020_3d_multiGPU.py | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

(limited to 'python')

diff --git a/python/astra/__init__.py b/python/astra/__init__.py
index b73fff5..d5aac44 100644
--- a/python/astra/__init__.py
+++ b/python/astra/__init__.py
@@ -27,6 +27,7 @@ from . import matlab as m
 from .creators import astra_dict,create_vol_geom, create_proj_geom, create_backprojection, create_sino, create_reconstruction, create_projector,create_sino3d_gpu, create_backprojection3d_gpu
 from .functions import data_op, add_noise_to_sino, clear, move_vol_geom
 from .extrautils import clipCircle
+from .astra import set_gpu_index, get_gpu_info
 from . import data2d
 from . import astra
 from . import data3d
@@ -45,4 +46,4 @@ import os
 
 if 'ASTRA_GPU_INDEX' in os.environ:
     L = [ int(x) for x in os.environ['ASTRA_GPU_INDEX'].split(',') ]
-    astra.set_gpu_index(L)
+    set_gpu_index(L)
diff --git a/samples/python/s020_3d_multiGPU.py b/samples/python/s020_3d_multiGPU.py
index 11a1e11..e872870 100644
--- a/samples/python/s020_3d_multiGPU.py
+++ b/samples/python/s020_3d_multiGPU.py
@@ -28,11 +28,11 @@ import numpy as np
 
 # Set up multi-GPU usage.
 # This only works for 3D GPU forward projection and back projection.
-astra.astra.set_gpu_index([0,1])
+astra.set_gpu_index([0,1])
 
 # Optionally, you can also restrict the amount of GPU memory ASTRA will use.
 # The line commented below sets this to 1GB.
-#astra.astra.set_gpu_index([0,1], memory=1024*1024*1024)
+#astra.set_gpu_index([0,1], memory=1024*1024*1024)
 
 vol_geom = astra.create_vol_geom(1024, 1024, 1024)
 
-- 
cgit v1.2.3


From 3eaebe8827db8ddf029fdb94ccda2b0af1385bec Mon Sep 17 00:00:00 2001
From: Willem Jan Palenstijn <wjp@usecode.org>
Date: Tue, 17 Oct 2017 21:07:28 +0200
Subject: Add basic post-install python tests

---
 .travis.yml              |  2 +-
 README.md                | 11 ++++++
 README.txt               | 16 ++++++++
 python/astra/__init__.py |  1 +
 python/astra/tests.py    | 97 ++++++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 126 insertions(+), 1 deletion(-)
 create mode 100644 python/astra/tests.py

(limited to 'python')

diff --git a/.travis.yml b/.travis.yml
index b34b1a0..aca9940 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -69,4 +69,4 @@ script:
   - make -j 4
   - make test
   - make install
-  - python -c "import astra"
+  - python -c "import astra; astra.test_noCUDA()"
diff --git a/README.md b/README.md
index 5211e69..ddc881c 100644
--- a/README.md
+++ b/README.md
@@ -123,6 +123,17 @@ Run build_setup.bat to automatically copy the boost headers and libraries.
 For matlab: Run build_matlab.bat. The .dll and .mexw64 files will be in bin\x64\Release_Cuda.
 For python 2.7/3.5: Run build_python27.bat or build_python35.bat. Astra will be directly installed into site-packages.
 
+## Testing your installation
+
+To perform a (very) basic test of your ASTRA installation in Python, you can
+run the following Python commands. You can choose if you want to skip the test
+of the GPU functionality for systems without a NVIDIA GPU.
+
+```
+import astra
+astra.test_noCUDA() # To skip GPU tests
+astra.test_CUDA()   # To also perform GPU tests
+```
 
 
 ## References
diff --git a/README.txt b/README.txt
index 94da3d4..63c9cf5 100644
--- a/README.txt
+++ b/README.txt
@@ -151,6 +151,22 @@ For matlab: Run build_matlab.bat. The .dll and .mexw64 files will be in bin\x64\
 For python 2.7/3.5: Run build_python27.bat or build_python35.bat. Astra will be directly installed into site-packages.
 
 
+Testing your installation:
+---------------------------
+
+To perform a (very) basic test of your ASTRA installation in Python, you can
+run the following Python commands. You can choose if you want to skip the test
+of the GPU functionality for systems without a NVIDIA GPU.
+
+import astra
+astra.test_noCUDA() # To skip GPU tests
+astra.test_CUDA()   # To also perform GPU tests
+
+
+
+
+
+
 References:
 ------------
 
diff --git a/python/astra/__init__.py b/python/astra/__init__.py
index d5aac44..8238a88 100644
--- a/python/astra/__init__.py
+++ b/python/astra/__init__.py
@@ -39,6 +39,7 @@ from . import plugin
 from . import plugins
 from . import log
 from .optomo import OpTomo
+from .tests import test_noCUDA, test_CUDA
 
 __version__ = '1.8'
 
diff --git a/python/astra/tests.py b/python/astra/tests.py
new file mode 100644
index 0000000..32afd36
--- /dev/null
+++ b/python/astra/tests.py
@@ -0,0 +1,97 @@
+# -----------------------------------------------------------------------
+# Copyright: 2010-2017, iMinds-Vision Lab, University of Antwerp
+#            2013-2017, CWI, Amsterdam
+#
+# Contact: astra@uantwerpen.be
+# Website: http://www.astra-toolbox.com/
+#
+# This file is part of the ASTRA Toolbox.
+#
+#
+# The ASTRA Toolbox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# The ASTRA Toolbox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with the ASTRA Toolbox. If not, see <http://www.gnu.org/licenses/>.
+#
+# -----------------------------------------------------------------------
+
+from __future__ import print_function, absolute_import
+
+def _basic_par2d_fp(type):
+  import astra
+  import numpy as np
+  vg = astra.create_vol_geom(2, 32)
+  pg = astra.create_proj_geom('parallel', 1, 32, [0])
+  proj_id = astra.create_projector(type, pg, vg)
+  vol = np.random.rand(2, 32)
+  (sino_id, sino) = astra.create_sino(vol, proj_id)
+  astra.data2d.delete(sino_id)
+  astra.projector.delete(proj_id)
+  err = np.max(np.abs(sino[0,:] - np.sum(vol,axis=0)))
+  return err < 1e-6
+
+def _basic_par3d_fp():
+  import astra
+  import numpy as np
+  vg = astra.create_vol_geom(2, 32, 32)
+  pg = astra.create_proj_geom('parallel3d', 1, 1, 32, 32, [0])
+  vol = np.random.rand(32, 2, 32)
+  (sino_id, sino) = astra.create_sino3d_gpu(vol, pg, vg)
+  astra.data3d.delete(sino_id)
+  err = np.max(np.abs(sino[:,0,:] - np.sum(vol,axis=1)))
+  return err < 1e-6
+
+
+def _basic_par2d():
+  print("Testing basic CPU 2D functionality... ", end="")
+  if _basic_par2d_fp('line'):
+    print("Ok")
+    return True
+  else:
+    print("Error")
+    return False
+
+def _basic_par2d_cuda():
+  print("Testing basic CUDA 2D functionality... ", end="")
+  if _basic_par2d_fp('cuda'):
+    print("Ok")
+    return True
+  else:
+    print("Error")
+    return False
+
+def _basic_par3d_cuda():
+  print("Testing basic CUDA 3D functionality... ", end="")
+  if _basic_par3d_fp():
+    print("Ok")
+    return True
+  else:
+    print("Error")
+    return False
+
+def test_noCUDA():
+  """Perform a very basic functionality test, without CUDA"""
+  
+  ok = _basic_par2d()
+  if not ok:
+    raise RuntimeError("Test failed")
+
+def test_CUDA():
+  """Perform a very basic functionality test, including CUDA"""
+  
+  import astra
+  print("Getting GPU info... ", end="")
+  print(astra.get_gpu_info())
+  ok1 = _basic_par2d()
+  ok2 = _basic_par2d_cuda()
+  ok3 = _basic_par3d_cuda()
+  if not (ok1 and ok2 and ok3):
+    raise RuntimeError("Test failed")
-- 
cgit v1.2.3


From 1642ceef7cb622e530b30232536b31bb43ac7ed9 Mon Sep 17 00:00:00 2001
From: Willem Jan Palenstijn <Willem.Jan.Palenstijn@cwi.nl>
Date: Mon, 30 Oct 2017 16:29:04 +0100
Subject: Add libastra/linux-64 conda package variants for cudatoolkit

Also upgrade the Docker-based linux release scripts to match.
---
 python/conda/astra-toolbox/build.sh                |  8 ++-
 python/conda/astra-toolbox/conda_build_config.yaml |  9 +++
 python/conda/astra-toolbox/meta.yaml               |  8 +--
 python/conda/libastra/build.sh                     | 31 ++++++++--
 python/conda/libastra/linux_build_config.yaml      |  6 ++
 python/conda/libastra/meta.yaml                    | 11 ++--
 python/conda/linux_release/buildenv/Dockerfile     | 66 +++++++++++++++++-----
 python/conda/linux_release/buildenv/build.sh       | 13 +++++
 python/conda/linux_release/builder/Dockerfile      | 17 ------
 python/conda/linux_release/release.sh              | 16 +++---
 10 files changed, 130 insertions(+), 55 deletions(-)
 create mode 100644 python/conda/astra-toolbox/conda_build_config.yaml
 create mode 100644 python/conda/libastra/linux_build_config.yaml
 create mode 100644 python/conda/linux_release/buildenv/build.sh
 delete mode 100644 python/conda/linux_release/builder/Dockerfile

(limited to 'python')

diff --git a/python/conda/astra-toolbox/build.sh b/python/conda/astra-toolbox/build.sh
index 951fd88..0468037 100644
--- a/python/conda/astra-toolbox/build.sh
+++ b/python/conda/astra-toolbox/build.sh
@@ -1,4 +1,10 @@
 #!/bin/sh
 
+case `uname` in
+  Darwin*)
+    CC="gcc -stdlib=libstdc++"
+    ;;
+esac
+
 cd $SRC_DIR/python/
-CPPFLAGS="-DASTRA_CUDA -DASTRA_PYTHON $CPPFLAGS -I$SRC_DIR/ -I$SRC_DIR/include -I$CUDA_ROOT/include" CC=$CC python ./builder.py build install
+CPPFLAGS="-DASTRA_CUDA -DASTRA_PYTHON $CPPFLAGS -I$SRC_DIR/ -I$SRC_DIR/include" CC=$CC python ./builder.py build install
diff --git a/python/conda/astra-toolbox/conda_build_config.yaml b/python/conda/astra-toolbox/conda_build_config.yaml
new file mode 100644
index 0000000..bd38ac6
--- /dev/null
+++ b/python/conda/astra-toolbox/conda_build_config.yaml
@@ -0,0 +1,9 @@
+python:
+  - 2.7
+  - 3.5
+  - 3.6
+
+numpy:
+  - 1.11
+  - 1.12
+  - 1.13
diff --git a/python/conda/astra-toolbox/meta.yaml b/python/conda/astra-toolbox/meta.yaml
index 942397e..f3a39be 100644
--- a/python/conda/astra-toolbox/meta.yaml
+++ b/python/conda/astra-toolbox/meta.yaml
@@ -9,13 +9,11 @@ source:
 build:
   number: 0
   script_env:
-    - CC # [not win]
-    - CUDA_ROOT # [not win]
+    - CC # [linux]
 
 test:
   imports:
     - astra
-
   requires:
     # To avoid large downloads just for testing after build phase
     - nomkl # [not win]
@@ -25,14 +23,14 @@ requirements:
     - python
     - cython >=0.13
     - nomkl # [not win]
-    - numpy
+    - numpy {{ numpy }}
     - scipy
     - six
     - libastra ==1.8
 
   run:
     - python
-    - numpy x.x
+    - {{ pin_compatible('numpy', max_pin='x.x') }}
     - scipy
     - six
     - libastra ==1.8
diff --git a/python/conda/libastra/build.sh b/python/conda/libastra/build.sh
index 304c053..aa9a4ce 100644
--- a/python/conda/libastra/build.sh
+++ b/python/conda/libastra/build.sh
@@ -1,5 +1,19 @@
 #!/bin/sh
 
+case `uname` in
+  Darwin*)
+    CUDA_ROOT=/usr/local/cuda
+    CC=gcc
+    CXX=g++
+    ;;
+  Linux*)
+    [ -n "$cudatoolkit" ] || exit 1
+    CUDA_ROOT=/usr/local/cuda-$cudatoolkit
+    ;;
+esac
+
+[ -x "$CUDA_ROOT" ] || exit 1
+
 cd $SRC_DIR/build/linux
 
 $SRC_DIR/build/linux/autogen.sh
@@ -12,7 +26,11 @@ rm -f $CONDA_PREFIX/test.out
 
 $SRC_DIR/build/linux/configure --with-install-type=prefix --with-cuda=$CUDA_ROOT --prefix=$CONDA_PREFIX NVCCFLAGS="-ccbin $CC -I$CONDA_PREFIX/include $EXTRA_NVCCFLAGS" CC=$CC CXX=$CXX CPPFLAGS="-I$CONDA_PREFIX/include"
 
-make install-libraries
+# Clean, because we may be re-using this source tree when building
+# multiple variants of this conda package.
+make clean
+
+make -j $CPU_COUNT install-libraries
 
 
 test -d $CUDA_ROOT/lib64 && LIBPATH="$CUDA_ROOT/lib64" || LIBPATH="$CUDA_ROOT/lib"
@@ -22,8 +40,13 @@ case `uname` in
     cp -P $LIBPATH/libcudart.*.dylib $CONDA_PREFIX/lib
     cp -P $LIBPATH/libcufft.*.dylib $CONDA_PREFIX/lib
     ;;
-  *)
-    cp -P $LIBPATH/libcudart.so.* $CONDA_PREFIX/lib
-    cp -P $LIBPATH/libcufft.so.* $CONDA_PREFIX/lib
+  Linux*)
+    if [ "$cudatoolkit" = "7.0" ]; then
+      # For some reason conda-build adds these symlinks automatically for
+      # cudatoolkit-5.5 and 6.0, but not 7.0. For 7.5 these symlinks are not
+      # necessary, and for 8.0 the cudatoolkit packages includes them.
+      ln -T -s libcudart.so.7.0.28 $CONDA_PREFIX/lib/libcudart.so.7.0
+      ln -T -s libcufft.so.7.0.35 $CONDA_PREFIX/lib/libcufft.so.7.0
+    fi
     ;;
 esac
diff --git a/python/conda/libastra/linux_build_config.yaml b/python/conda/libastra/linux_build_config.yaml
new file mode 100644
index 0000000..c5d2319
--- /dev/null
+++ b/python/conda/libastra/linux_build_config.yaml
@@ -0,0 +1,6 @@
+cudatoolkit:
+  - 5.5
+  - 6.0
+  - 7.0
+  - 7.5
+  - 8.0
diff --git a/python/conda/libastra/meta.yaml b/python/conda/libastra/meta.yaml
index 68cf47a..6176f30 100644
--- a/python/conda/libastra/meta.yaml
+++ b/python/conda/libastra/meta.yaml
@@ -9,9 +9,8 @@ source:
 build:
   number: 0
   script_env:
-    - CC # [not win]
-    - CXX # [not win]
-    - CUDA_ROOT # [not win]
+    - CC # [linux]
+    - CXX # [linux]
 
 requirements:
   build:
@@ -20,15 +19,13 @@ requirements:
     - automake # [osx]
     - autoconf # [osx]
     - libtool # [osx]
+    - cudatoolkit {{ cudatoolkit }} # [linux]
 
   run:
     - vs2015_runtime # [win]
+    - cudatoolkit {{ cudatoolkit }} # [linux]
 
 about:
   home: http://www.astra-toolbox.com
   license: GPLv3
   summary: 'The ASTRA Toolbox is a Python toolbox of high-performance GPU primitives for 2D and 3D tomography.'
-
-# See
-# http://docs.continuum.io/conda/build.html for
-# more information about meta.yaml
diff --git a/python/conda/linux_release/buildenv/Dockerfile b/python/conda/linux_release/buildenv/Dockerfile
index ce0b63b..17e9c5b 100644
--- a/python/conda/linux_release/buildenv/Dockerfile
+++ b/python/conda/linux_release/buildenv/Dockerfile
@@ -1,15 +1,55 @@
-FROM debian:7
-ENV PATH /root/miniconda3/bin:$PATH
+FROM debian:7 AS BUILDBASE
 ENV DEBIAN_FRONTEND noninteractive
-# http://developer.download.nvidia.com/compute/cuda/5_5/rel/installers/cuda_5.5.22_linux_64.run
-ADD cuda_5.5.22_linux_64.run /root/
-# https://repo.continuum.io/miniconda/Miniconda3-4.3.27.1-Linux-x86_64.sh
-ADD Miniconda3-4.3.27.1-Linux-x86_64.sh /root/
-RUN apt-get update
-RUN apt-get install -y perl-modules build-essential autoconf libtool automake libboost-dev git
-RUN /bin/bash /root/Miniconda3-4.3.27.1-Linux-x86_64.sh -b
-RUN /bin/bash /root/cuda_5.5.22_linux_64.run -toolkit -silent
+RUN apt-get update && apt-get install -y perl-modules build-essential autoconf libtool automake libboost-dev git && rm -rf /var/lib/apt/lists/*
+
+FROM BUILDBASE AS CUDA80
+RUN touch /root/cuda80
+COPY cuda_8.0.61_375.26_linux-run /root
+RUN /bin/bash /root/cuda_8.0.61_375.26_linux-run --toolkit --silent && \
+	rm -f /root/cuda_8.0.61_375.26_linux-run
+COPY cuda_8.0.61.2_linux-run /root
+RUN /bin/bash /root/cuda_8.0.61.2_linux-run --silent --accept-eula && \
+	rm -f /root/cuda_8.0.61.2_linux-run
+
+FROM BUILDBASE AS CUDA75
+RUN touch /root/cuda75
+COPY cuda_7.5.18_linux.run /root
+RUN /bin/bash /root/cuda_7.5.18_linux.run --toolkit --silent && \
+	rm -f /root/cuda_7.5.18_linux.run
+
+FROM BUILDBASE AS CUDA70
+RUN touch /root/cuda70
+COPY cuda_7.0.28_linux.run /root
+RUN /bin/bash /root/cuda_7.0.28_linux.run -toolkit -silent && \
+	rm -f /root/cuda_7.0.28_linux.run
+
+COPY cufft_patch_linux.tar.gz /root
+RUN cd /usr/local/cuda-7.0 && \
+	tar xf /root/cufft_patch_linux.tar.gz && \
+	rm -f /root/cufft_patch_linux.tar.gz
+
+FROM BUILDBASE AS CUDA60
+RUN touch /root/cuda60
+COPY cuda_6.0.37_linux_64.run /root
+RUN /bin/bash /root/cuda_6.0.37_linux_64.run -toolkit -silent && \
+	rm -f /root/cuda_6.0.37_linux_64.run
+
+FROM BUILDBASE AS CUDA55
+RUN touch /root/cuda55
+COPY cuda_5.5.22_linux_64.run /root
+RUN /bin/bash /root/cuda_5.5.22_linux_64.run -toolkit -silent && \
+	rm /root/cuda_5.5.22_linux_64.run
+
+FROM BUILDBASE
+RUN touch /root/cuda
+COPY --from=CUDA80 /usr/local/cuda-8.0 /usr/local/cuda-8.0
+COPY --from=CUDA75 /usr/local/cuda-7.5 /usr/local/cuda-7.5
+COPY --from=CUDA70 /usr/local/cuda-7.0 /usr/local/cuda-7.0
+COPY --from=CUDA60 /usr/local/cuda-6.0 /usr/local/cuda-6.0
+COPY --from=CUDA55 /usr/local/cuda-5.5 /usr/local/cuda-5.5
+
+ENV PATH /root/miniconda3/bin:$PATH
+COPY Miniconda3-4.3.27.1-Linux-x86_64.sh /root/
+RUN /bin/bash /root/Miniconda3-4.3.27.1-Linux-x86_64.sh -b && \
+	rm -f /root/Miniconda3*
 RUN conda install -y conda-build
-ENV CUDA_ROOT /usr/local/cuda
-ENV CC gcc
-ENV CXX g++
diff --git a/python/conda/linux_release/buildenv/build.sh b/python/conda/linux_release/buildenv/build.sh
new file mode 100644
index 0000000..1cc0830
--- /dev/null
+++ b/python/conda/linux_release/buildenv/build.sh
@@ -0,0 +1,13 @@
+#!/bin/sh
+
+export CC=gcc
+export CXX=g++
+
+cd /root
+git clone --depth 1 --branch master https://github.com/astra-toolbox/astra-toolbox
+[ $# -eq 0 ] || perl -pi -e "s/^(\s*number:\s*)[0-9]+$/\${1}$1/" astra-toolbox/python/conda/libastra/meta.yaml astra-toolbox/python/conda/astra-toolbox/meta.yaml
+
+conda-build -m astra-toolbox/python/conda/libastra/linux_build_config.yaml astra-toolbox/python/conda/libastra
+conda-build astra-toolbox/python/conda/astra-toolbox
+
+cp /root/miniconda3/conda-bld/linux-64/*astra* /out
diff --git a/python/conda/linux_release/builder/Dockerfile b/python/conda/linux_release/builder/Dockerfile
deleted file mode 100644
index 2404609..0000000
--- a/python/conda/linux_release/builder/Dockerfile
+++ /dev/null
@@ -1,17 +0,0 @@
-FROM astra-build-env
-ARG BUILD_NUMBER=
-WORKDIR /root
-RUN git clone --depth 1 https://github.com/astra-toolbox/astra-toolbox
-RUN [ -z $BUILD_NUMBER ] || perl -pi -e "s/^(\s*number:\s*)[0-9]+$/\${1}$BUILD_NUMBER/" astra-toolbox/python/conda/libastra/meta.yaml astra-toolbox/python/conda/astra-toolbox/meta.yaml
-RUN conda-build --python=3.5 astra-toolbox/python/conda/libastra
-RUN conda-build --python 2.7 --numpy 1.8 astra-toolbox/python/conda/astra-toolbox
-RUN conda-build --python 2.7 --numpy 1.9 astra-toolbox/python/conda/astra-toolbox
-RUN conda-build --python 2.7 --numpy 1.10 astra-toolbox/python/conda/astra-toolbox
-RUN conda-build --python 2.7 --numpy 1.11 astra-toolbox/python/conda/astra-toolbox
-RUN conda-build --python 2.7 --numpy 1.12 astra-toolbox/python/conda/astra-toolbox
-RUN conda-build --python 3.5 --numpy 1.9 astra-toolbox/python/conda/astra-toolbox
-RUN conda-build --python 3.5 --numpy 1.10 astra-toolbox/python/conda/astra-toolbox
-RUN conda-build --python 3.5 --numpy 1.11 astra-toolbox/python/conda/astra-toolbox
-RUN conda-build --python 3.5 --numpy 1.12 astra-toolbox/python/conda/astra-toolbox
-RUN conda-build --python 3.6 --numpy 1.11 astra-toolbox/python/conda/astra-toolbox
-RUN conda-build --python 3.6 --numpy 1.12 astra-toolbox/python/conda/astra-toolbox
diff --git a/python/conda/linux_release/release.sh b/python/conda/linux_release/release.sh
index 089cc7c..91c13e4 100644
--- a/python/conda/linux_release/release.sh
+++ b/python/conda/linux_release/release.sh
@@ -2,19 +2,19 @@
 
 D=`mktemp -d`
 
-[ -f buildenv/cuda_5.5.22_linux_64.run ] || (cd buildenv; wget http://developer.download.nvidia.com/compute/cuda/5_5/rel/installers/cuda_5.5.22_linux_64.run )
-[ -f buildenv/Miniconda3-4.3.27.1-Linux-x86_64.sh ] || (cd buildenv; wget https://repo.continuum.io/miniconda/Miniconda3-4.3.27.1-Linux-x86_64.sh )
+for F in https://repo.continuum.io/miniconda/Miniconda3-4.2.12-Linux-x86_64.sh  http://developer.download.nvidia.com/compute/cuda/5_5/rel/installers/cuda_5.5.22_linux_64.run http://developer.download.nvidia.com/compute/cuda/6_0/rel/installers/cuda_6.0.37_linux_64.run  http://developer.download.nvidia.com/compute/cuda/7_0/Prod/local_installers/cuda_7.0.28_linux.run http://developer.download.nvidia.com/compute/cuda/7_0/Prod/cufft_update/cufft_patch_linux.tar.gz http://developer.download.nvidia.com/compute/cuda/7.5/Prod/local_installers/cuda_7.5.18_linux.run https://developer.nvidia.com/compute/cuda/8.0/Prod2/local_installers/cuda_8.0.61_375.26_linux-run https://developer.nvidia.com/compute/cuda/8.0/Prod2/patches/2/cuda_8.0.61.2_linux-run; do
+	[ -f buildenv/`basename $F` ] || (cd buildenv; wget $F )
+done
 
 docker build -t astra-build-env buildenv
-#docker build --no-cache --build-arg=BUILD_NUMBER=0 -t astra-builder builder
-docker build --no-cache -t astra-builder builder
 
-docker run --name astra-build-cnt -v $D:/out:z astra-builder /bin/bash -c "cp /root/miniconda3/conda-bld/linux-64/*astra* /out"
+cp buildenv/build.sh $D
+
+docker run -v $D:/out:z astra-build-env /bin/bash /out/build.sh
+
+rm -f $D/build.sh
 
 mkdir -p pkgs
 mv $D/* pkgs
 rmdir $D
 
-docker rm astra-build-cnt
-docker rmi astra-builder
-
-- 
cgit v1.2.3


From 4637704745849cf60ab951f941d5b81fd6fe55dc Mon Sep 17 00:00:00 2001
From: Willem Jan Palenstijn <Willem.Jan.Palenstijn@cwi.nl>
Date: Mon, 6 Nov 2017 14:03:18 +0100
Subject: Add workaround for apparently broken mkl/win-64 conda package

---
 python/conda/astra-toolbox/meta.yaml | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'python')

diff --git a/python/conda/astra-toolbox/meta.yaml b/python/conda/astra-toolbox/meta.yaml
index f3a39be..2b25c44 100644
--- a/python/conda/astra-toolbox/meta.yaml
+++ b/python/conda/astra-toolbox/meta.yaml
@@ -17,6 +17,8 @@ test:
   requires:
     # To avoid large downloads just for testing after build phase
     - nomkl # [not win]
+    # import scipy.sparse.linalg fails with mkl-2017.0.4 on Windows
+    - mkl !=2017.0.4 # [win]
 
 requirements:
   build:
-- 
cgit v1.2.3


From bfceef4da377c32cd59d1e51efb9aa1a21c7f4bd Mon Sep 17 00:00:00 2001
From: Willem Jan Palenstijn <Willem.Jan.Palenstijn@cwi.nl>
Date: Mon, 6 Nov 2017 14:40:01 +0100
Subject: Update version to 1.8.3

---
 build/linux/configure.ac             | 2 +-
 build/msvc/build_env.bat             | 4 ++--
 include/astra/Globals.h              | 2 +-
 python/astra/__init__.py             | 2 +-
 python/builder.py                    | 2 +-
 python/conda/astra-toolbox/meta.yaml | 8 ++++----
 python/conda/libastra/meta.yaml      | 4 ++--
 7 files changed, 12 insertions(+), 12 deletions(-)

(limited to 'python')

diff --git a/build/linux/configure.ac b/build/linux/configure.ac
index b95d94f..0091388 100644
--- a/build/linux/configure.ac
+++ b/build/linux/configure.ac
@@ -23,7 +23,7 @@ dnl along with the ASTRA Toolbox. If not, see <http://www.gnu.org/licenses/>.
 dnl
 dnl -----------------------------------------------------------------------
 
-AC_INIT(astra, 1.8.0)
+AC_INIT(astra, 1.8.3)
 AC_CONFIG_SRCDIR([Makefile.in])
 LT_INIT([disable-static])
 
diff --git a/build/msvc/build_env.bat b/build/msvc/build_env.bat
index 8cb7c96..56c811f 100644
--- a/build/msvc/build_env.bat
+++ b/build/msvc/build_env.bat
@@ -12,5 +12,5 @@ set B_VCREDIST=D:\wjp\vs2015u3_redist\vc_redist.x64.exe
 set B_README_WP27=C:\WinPython-64bit-%B_WP27%\python-%B_WP27:~0,-2%.amd64\Lib\site-packages
 set B_README_WP35=C:\WinPython-64bit-%B_WP35%\python-%B_WP35:~0,-2%.amd64\Lib\site-packages
 
-set B_RELEASE_TAG=v1.8
-set B_RELEASE=1.8
+set B_RELEASE_TAG=v1.8.3
+set B_RELEASE=1.8.3
diff --git a/include/astra/Globals.h b/include/astra/Globals.h
index 7c1e9a8..f447fd8 100644
--- a/include/astra/Globals.h
+++ b/include/astra/Globals.h
@@ -60,7 +60,7 @@ along with the ASTRA Toolbox. If not, see <http://www.gnu.org/licenses/>.
 #define ASTRA_TOOLBOXVERSION_MAJOR 1
 #define ASTRA_TOOLBOXVERSION_MINOR 8
 #define ASTRA_TOOLBOXVERSION ((ASTRA_TOOLBOXVERSION_MAJOR)*100 + (ASTRA_TOOLBOXVERSION_MINOR))
-#define ASTRA_TOOLBOXVERSION_STRING "1.8"
+#define ASTRA_TOOLBOXVERSION_STRING "1.8.3"
 
 
 #define ASTRA_ASSERT(a) assert(a)
diff --git a/python/astra/__init__.py b/python/astra/__init__.py
index 8238a88..5e52a1c 100644
--- a/python/astra/__init__.py
+++ b/python/astra/__init__.py
@@ -41,7 +41,7 @@ from . import log
 from .optomo import OpTomo
 from .tests import test_noCUDA, test_CUDA
 
-__version__ = '1.8'
+__version__ = '1.8.3'
 
 import os
 
diff --git a/python/builder.py b/python/builder.py
index ec0bd23..01f4203 100644
--- a/python/builder.py
+++ b/python/builder.py
@@ -71,7 +71,7 @@ for m in ext_modules:
                                       'PythonPluginAlgorithm.cpp'))
 
 setup(name='astra-toolbox',
-      version='1.8',
+      version='1.8.3',
       description='Python interface to the ASTRA Toolbox',
       author='D.M. Pelt',
       author_email='D.M.Pelt@cwi.nl',
diff --git a/python/conda/astra-toolbox/meta.yaml b/python/conda/astra-toolbox/meta.yaml
index 2b25c44..88a9172 100644
--- a/python/conda/astra-toolbox/meta.yaml
+++ b/python/conda/astra-toolbox/meta.yaml
@@ -1,10 +1,10 @@
 package:
   name: astra-toolbox
-  version: '1.8'
+  version: '1.8.3'
 
 source:
   git_url: https://github.com/astra-toolbox/astra-toolbox.git
-  git_tag: v1.8
+  git_tag: v1.8.3
 
 build:
   number: 0
@@ -28,14 +28,14 @@ requirements:
     - numpy {{ numpy }}
     - scipy
     - six
-    - libastra ==1.8
+    - libastra ==1.8.3
 
   run:
     - python
     - {{ pin_compatible('numpy', max_pin='x.x') }}
     - scipy
     - six
-    - libastra ==1.8
+    - libastra ==1.8.3
 
 
 about:
diff --git a/python/conda/libastra/meta.yaml b/python/conda/libastra/meta.yaml
index 6176f30..e4622b7 100644
--- a/python/conda/libastra/meta.yaml
+++ b/python/conda/libastra/meta.yaml
@@ -1,10 +1,10 @@
 package:
   name: libastra
-  version: '1.8'
+  version: '1.8.3'
 
 source:
   git_url: https://github.com/astra-toolbox/astra-toolbox.git
-  git_tag: v1.8
+  git_tag: v1.8.3
 
 build:
   number: 0
-- 
cgit v1.2.3


From bd2798bed2fddfe00dac006013a9fb1363417f20 Mon Sep 17 00:00:00 2001
From: Willem Jan Palenstijn <Willem.Jan.Palenstijn@cwi.nl>
Date: Tue, 14 Nov 2017 14:56:02 +0100
Subject: Remove unused code

---
 include/astra/Float32Data3DMemory.h | 33 ++-------------------------------
 python/astra/PyIncludes.pxd         |  1 -
 python/astra/data3d_c.pyx           |  6 +++---
 src/Float32Data3DMemory.cpp         | 33 ---------------------------------
 4 files changed, 5 insertions(+), 68 deletions(-)

(limited to 'python')

diff --git a/include/astra/Float32Data3DMemory.h b/include/astra/Float32Data3DMemory.h
index 876aa37..4ebe60b 100644
--- a/include/astra/Float32Data3DMemory.h
+++ b/include/astra/Float32Data3DMemory.h
@@ -52,22 +52,10 @@ protected:
 	 */
 	 float32* m_pfData;	
 
-	/** Array of float32 pointers, each pointing to a single row 
-	 * in the m_pfData memory block.
-	 * To access element (ix, iy, iz) internally, use m_ppfDataRowInd[iz * m_iHeight + iy][ix]
-	*/
-	float32** m_ppfDataRowInd;
-
-	/** Array of float32 pointers, each pointing to a single slice 
-	 * in the m_pfData memory block.
-	 * To access element (ix, iy, iz) internally, use m_pppfDataSliceInd[iz][iy][ix]
-	*/
-	float32*** m_pppfDataSliceInd;	
-
 	float32 m_fGlobalMin;	///< minimum value of the data
 	float32 m_fGlobalMax;	///< maximum value of the data
 
-	/** Allocate memory for m_pfData, m_ppfDataRowInd and m_pppfDataSliceInd arrays.
+	/** Allocate memory for m_pfData.
 	 *
 	 * The allocated block consists of m_iSize float32s. The block is
 	 * not cleared after allocation and its contents is undefined. 
@@ -75,7 +63,7 @@ protected:
 	 */
 	void _allocateData();
 
-	/** Free memory for m_pfData, m_ppfDataRowInd and m_pppfDataSliceInd arrays.
+	/** Free memory for m_pfData.
 	 *
 	 * This function may ONLY be called if the memory for both blocks has been 
 	 * allocated before.
@@ -299,23 +287,6 @@ inline const float32* CFloat32Data3DMemory::getDataConst() const
 	return (const float32*)m_pfData;
 }
 
-//----------------------------------------------------------------------------------------
-// Get a float32** to the data block, represented as a 3-dimensional array of float32 values.
-inline float32*** CFloat32Data3DMemory::getData3D()
-{
-	ASTRA_ASSERT(m_bInitialized);
-	return m_pppfDataSliceInd;
-}
-
-//----------------------------------------------------------------------------------------
-// Get a const float32** to the data block, represented as a 3-dimensional array of float32 values.
-inline const float32*** CFloat32Data3DMemory::getData3DConst() const
-{
-	ASTRA_ASSERT(m_bInitialized);
-	return (const float32***)m_pppfDataSliceInd;
-}
-//----------------------------------------------------------------------------------------
-
 } // end namespace astra
 
 #endif // _INC_ASTRA_FLOAT32DATA2D
diff --git a/python/astra/PyIncludes.pxd b/python/astra/PyIncludes.pxd
index 512b82f..ec37d0a 100644
--- a/python/astra/PyIncludes.pxd
+++ b/python/astra/PyIncludes.pxd
@@ -211,7 +211,6 @@ cdef extern from "astra/Float32Data3DMemory.h" namespace "astra":
         CFloat32Data3DMemory()
         void updateStatistics()
         float32 *getData()
-        float32 ***getData3D()
         THREEEDataType getType()
 
 
diff --git a/python/astra/data3d_c.pyx b/python/astra/data3d_c.pyx
index 0717ca0..897634b 100644
--- a/python/astra/data3d_c.pyx
+++ b/python/astra/data3d_c.pyx
@@ -254,7 +254,7 @@ cdef fillDataObjectScalar(CFloat32Data3DMemory * obj, float s):
 @cython.boundscheck(False)
 @cython.wraparound(False)
 cdef fillDataObjectArray(CFloat32Data3DMemory * obj, float [:,:,::1] data):
-    cdef float [:,:,::1] cView = <float[:data.shape[0],:data.shape[1],:data.shape[2]]> obj.getData3D()[0][0]
+    cdef float [:,:,::1] cView = <float[:data.shape[0],:data.shape[1],:data.shape[2]]> obj.getData()
     cView[:] = data
 
 cdef CFloat32Data3D * getObject(i) except NULL:
@@ -271,7 +271,7 @@ def get(i):
     cdef CFloat32Data3DMemory * pDataObject = dynamic_cast_mem_safe(getObject(i))
     outArr = np.empty((pDataObject.getDepth(),pDataObject.getHeight(), pDataObject.getWidth()),dtype=np.float32,order='C')
     cdef float [:,:,::1] mView = outArr
-    cdef float [:,:,::1] cView = <float[:outArr.shape[0],:outArr.shape[1],:outArr.shape[2]]> pDataObject.getData3D()[0][0]
+    cdef float [:,:,::1] cView = <float[:outArr.shape[0],:outArr.shape[1],:outArr.shape[2]]> pDataObject.getData()
     mView[:] = cView
     return outArr
 
@@ -282,7 +282,7 @@ def get_shared(i):
     shape[0] = <np.npy_intp> pDataObject.getDepth()
     shape[1] = <np.npy_intp> pDataObject.getHeight()
     shape[2] = <np.npy_intp> pDataObject.getWidth()
-    return np.PyArray_SimpleNewFromData(3,shape,np.NPY_FLOAT32,<void *>pDataObject.getData3D()[0][0])
+    return np.PyArray_SimpleNewFromData(3,shape,np.NPY_FLOAT32,<void *>pDataObject.getData())
 
 def get_single(i):
     raise NotImplementedError("Not yet implemented")
diff --git a/src/Float32Data3DMemory.cpp b/src/Float32Data3DMemory.cpp
index 5c5c310..017625b 100644
--- a/src/Float32Data3DMemory.cpp
+++ b/src/Float32Data3DMemory.cpp
@@ -71,8 +71,6 @@ bool CFloat32Data3DMemory::_initialize(int _iWidth, int _iHeight, int _iDepth)
 
 	// allocate memory for the data, but do not fill it
 	m_pfData = NULL;
-	m_ppfDataRowInd = NULL;
-	m_pppfDataSliceInd = NULL;
 	m_pCustomMemory = 0;
 	_allocateData();
 
@@ -103,8 +101,6 @@ bool CFloat32Data3DMemory::_initialize(int _iWidth, int _iHeight, int _iDepth, c
 
 	// allocate memory for the data, but do not fill it
 	m_pfData = NULL;
-	m_ppfDataRowInd = NULL;
-	m_pppfDataSliceInd = NULL;
 	m_pCustomMemory = 0;
 	_allocateData();
 
@@ -140,8 +136,6 @@ bool CFloat32Data3DMemory::_initialize(int _iWidth, int _iHeight, int _iDepth, f
 
 	// allocate memory for the data, but do not fill it
 	m_pfData = NULL;
-	m_ppfDataRowInd = NULL;
-	m_pppfDataSliceInd = NULL;
 	m_pCustomMemory = 0;
 	_allocateData();
 
@@ -178,8 +172,6 @@ bool CFloat32Data3DMemory::_initialize(int _iWidth, int _iHeight, int _iDepth, C
 	// allocate memory for the data, but do not fill it
 	m_pCustomMemory = _pCustomMemory;
 	m_pfData = NULL;
-	m_ppfDataRowInd = NULL;
-	m_pppfDataSliceInd = NULL;
 	_allocateData();
 
 	// initialization complete
@@ -198,8 +190,6 @@ void CFloat32Data3DMemory::_allocateData()
 	ASTRA_ASSERT(m_iSize > 0);
 	ASTRA_ASSERT(m_iSize == (size_t)m_iWidth * m_iHeight * m_iDepth);
 	ASTRA_ASSERT(m_pfData == NULL);
-	ASTRA_ASSERT(m_ppfDataRowInd == NULL);
-	ASTRA_ASSERT(m_pppfDataSliceInd == NULL);
 
 	if (!m_pCustomMemory) {
 		// allocate contiguous block
@@ -213,20 +203,6 @@ void CFloat32Data3DMemory::_allocateData()
 	} else {
 		m_pfData = m_pCustomMemory->m_fPtr;
 	}
-
-	// create array of pointers to each row of the data block
-	m_ppfDataRowInd = new float32*[m_iHeight*m_iDepth];
-	for (int iy = 0; iy < m_iHeight*m_iDepth; iy++)
-	{
-		m_ppfDataRowInd[iy] = &(m_pfData[iy * m_iWidth]);
-	}
-
-	// create array of pointers to each row of the data block
-	m_pppfDataSliceInd = new float32**[m_iDepth];
-	for (int iy = 0; iy < m_iDepth; iy++)
-	{
-		m_pppfDataSliceInd[iy] = &(m_ppfDataRowInd[iy * m_iHeight]);
-	}
 }
 
 //----------------------------------------------------------------------------------------
@@ -235,13 +211,6 @@ void CFloat32Data3DMemory::_freeData()
 {
 	// basic checks
 	ASTRA_ASSERT(m_pfData != NULL);
-	ASTRA_ASSERT(m_ppfDataRowInd != NULL);
-	ASTRA_ASSERT(m_pppfDataSliceInd != NULL);
-
-	// free memory for index table
-	delete[] m_pppfDataSliceInd;
-	// free memory for index table
-	delete[] m_ppfDataRowInd;
 
 	if (!m_pCustomMemory) {
 		// free memory for data block
@@ -266,8 +235,6 @@ void CFloat32Data3DMemory::_clear()
 	m_iSize = 0;
 
 	m_pfData = NULL;
-	m_ppfDataRowInd = NULL;
-	m_pppfDataSliceInd = NULL;
 	m_pCustomMemory = NULL;
 }
 
-- 
cgit v1.2.3