From 9562adf37d853dd03531fde7b14e249736e10d88 Mon Sep 17 00:00:00 2001 From: Tomas Sedovic Date: Fri, 1 Dec 2017 12:14:20 +0100 Subject: Remove reading shell environment in rhel_subscribe The rhel_subscribe role used to read the shell environment variables for its input with a broken fallback to Ansible variables. This updates the role to only use Ansible vars. If the user wants to do an env lookup, they can do so when calling the role. --- roles/rhel_subscribe/tasks/enterprise.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'roles/rhel_subscribe/tasks/enterprise.yml') diff --git a/roles/rhel_subscribe/tasks/enterprise.yml b/roles/rhel_subscribe/tasks/enterprise.yml index fa74c9953..55e535d61 100644 --- a/roles/rhel_subscribe/tasks/enterprise.yml +++ b/roles/rhel_subscribe/tasks/enterprise.yml @@ -2,18 +2,11 @@ - name: Disable all repositories command: subscription-manager repos --disable="*" -- set_fact: - default_ose_version: '3.6' - when: deployment_type == 'openshift-enterprise' - -- set_fact: - ose_version: "{{ lookup('env', 'ose_version') | default(default_ose_version, True) }}" - - fail: msg: "{{ ose_version }} is not a valid version for {{ deployment_type }} deployment type" when: - deployment_type == 'openshift-enterprise' - - ose_version not in ['3.1', '3.2', '3.3', '3.4', '3.5', '3.6'] ) + - ose_version not in ['3.1', '3.2', '3.3', '3.4', '3.5', '3.6'] - name: Enable RHEL repositories command: subscription-manager repos \ -- cgit v1.2.3 From cbee76e15e860ccf3f40231e22c226f70a236faa Mon Sep 17 00:00:00 2001 From: Tomas Sedovic Date: Mon, 4 Dec 2017 17:14:54 +0100 Subject: Remove the ose_version check --- roles/rhel_subscribe/tasks/enterprise.yml | 6 ------ 1 file changed, 6 deletions(-) (limited to 'roles/rhel_subscribe/tasks/enterprise.yml') diff --git a/roles/rhel_subscribe/tasks/enterprise.yml b/roles/rhel_subscribe/tasks/enterprise.yml index 55e535d61..71f612b6e 100644 --- a/roles/rhel_subscribe/tasks/enterprise.yml +++ b/roles/rhel_subscribe/tasks/enterprise.yml @@ -2,12 +2,6 @@ - name: Disable all repositories command: subscription-manager repos --disable="*" -- fail: - msg: "{{ ose_version }} is not a valid version for {{ deployment_type }} deployment type" - when: - - deployment_type == 'openshift-enterprise' - - ose_version not in ['3.1', '3.2', '3.3', '3.4', '3.5', '3.6'] - - name: Enable RHEL repositories command: subscription-manager repos \ --enable="rhel-7-server-rpms" \ -- cgit v1.2.3 From 01fc87d824ea5bc96f29abee3aa27bb027f8bf5f Mon Sep 17 00:00:00 2001 From: Tomas Sedovic Date: Mon, 4 Dec 2017 17:17:51 +0100 Subject: Use openshift_release instead of ose_version --- roles/rhel_subscribe/tasks/enterprise.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'roles/rhel_subscribe/tasks/enterprise.yml') diff --git a/roles/rhel_subscribe/tasks/enterprise.yml b/roles/rhel_subscribe/tasks/enterprise.yml index 71f612b6e..48b04b209 100644 --- a/roles/rhel_subscribe/tasks/enterprise.yml +++ b/roles/rhel_subscribe/tasks/enterprise.yml @@ -6,7 +6,7 @@ command: subscription-manager repos \ --enable="rhel-7-server-rpms" \ --enable="rhel-7-server-extras-rpms" \ - --enable="rhel-7-server-ose-{{ ose_version }}-rpms" \ + --enable="rhel-7-server-ose-{{ openshift_release }}-rpms" \ --enable="rhel-7-fast-datapath-rpms" register: subscribe_repos until: subscribe_repos | succeeded -- cgit v1.2.3 From be5ef95fbb204470887887bf849a01e90b3d6d29 Mon Sep 17 00:00:00 2001 From: Tomas Sedovic Date: Tue, 5 Dec 2017 15:45:45 +0100 Subject: Get the correct value out of openshift_release The `openshift_release` contents can come in the form of `v3.6.0` which we need to turn to `3.6` to get the right repo name. --- roles/rhel_subscribe/tasks/enterprise.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'roles/rhel_subscribe/tasks/enterprise.yml') diff --git a/roles/rhel_subscribe/tasks/enterprise.yml b/roles/rhel_subscribe/tasks/enterprise.yml index 48b04b209..8acdfb969 100644 --- a/roles/rhel_subscribe/tasks/enterprise.yml +++ b/roles/rhel_subscribe/tasks/enterprise.yml @@ -1,4 +1,10 @@ --- +- set_fact: + openshift_release: "{{ openshift_release[1:] }}" + when: + - openshift_release is defined + - openshift_release[0] == 'v' + - name: Disable all repositories command: subscription-manager repos --disable="*" @@ -6,7 +12,7 @@ command: subscription-manager repos \ --enable="rhel-7-server-rpms" \ --enable="rhel-7-server-extras-rpms" \ - --enable="rhel-7-server-ose-{{ openshift_release }}-rpms" \ + --enable="rhel-7-server-ose-{{ (openshift_release | default('')).split('.')[0:2] | join('.') }}-rpms" \ --enable="rhel-7-fast-datapath-rpms" register: subscribe_repos until: subscribe_repos | succeeded -- cgit v1.2.3