From c667debd59e584530438198dfcf77403ed9c18c4 Mon Sep 17 00:00:00 2001
From: Kenny Woodson <kwoodson@redhat.com>
Date: Mon, 4 Apr 2016 16:07:02 -0400
Subject: Fixing regexp.  Periods are no longer allowed

---
 roles/lib_yaml_editor/library/yedit.py | 27 +++++++++++++++++++--------
 1 file changed, 19 insertions(+), 8 deletions(-)

(limited to 'roles/lib_yaml_editor/library/yedit.py')

diff --git a/roles/lib_yaml_editor/library/yedit.py b/roles/lib_yaml_editor/library/yedit.py
index 696ece63b..b7ae45b31 100644
--- a/roles/lib_yaml_editor/library/yedit.py
+++ b/roles/lib_yaml_editor/library/yedit.py
@@ -29,8 +29,8 @@ class YeditException(Exception):
 
 class Yedit(object):
     ''' Class to modify yaml files '''
-    re_valid_key = r"(((\[-?\d+\])|(\w+)).?)+$"
-    re_key = r"(?:\[(-?\d+)\])|(\w+)"
+    re_valid_key = r"(((\[-?\d+\])|([a-zA-Z-./]+)).?)+$"
+    re_key = r"(?:\[(-?\d+)\])|([a-zA-Z-./]+)"
 
     def __init__(self, filename=None, content=None, content_type='yaml'):
         self.content = content
@@ -70,11 +70,13 @@ class Yedit(object):
         if key_indexes[-1][0]:
             if isinstance(data, list) and int(key_indexes[-1][0]) <= len(data) - 1:
                 del data[int(key_indexes[-1][0])]
+                return True
 
         # expected dict entry
         elif key_indexes[-1][1]:
             if isinstance(data, dict):
                 del data[key_indexes[-1][1]]
+                return True
 
     @staticmethod
     def add_entry(data, key, item=None):
@@ -191,7 +193,7 @@ class Yedit(object):
         return entry
 
     def delete(self, key):
-        ''' put key, value into a yaml file '''
+        ''' remove key from a dict'''
         try:
             entry = Yedit.get_entry(self.yaml_dict, key)
         except KeyError as _:
@@ -199,11 +201,14 @@ class Yedit(object):
         if not entry:
             return  (False, self.yaml_dict)
 
-        Yedit.remove_entry(self.yaml_dict, key)
+        result = Yedit.remove_entry(self.yaml_dict, key)
+        if not result:
+            return (False, self.yaml_dict)
+
         return (True, self.yaml_dict)
 
     def put(self, key, value):
-        ''' put key, value into a yaml file '''
+        ''' put key, value into a dict '''
         try:
             entry = Yedit.get_entry(self.yaml_dict, key)
         except KeyError as _:
@@ -212,11 +217,14 @@ class Yedit(object):
         if entry == value:
             return (False, self.yaml_dict)
 
-        Yedit.add_entry(self.yaml_dict, key, value)
+        result = Yedit.add_entry(self.yaml_dict, key, value)
+        if not result:
+            return (False, self.yaml_dict)
+
         return (True, self.yaml_dict)
 
     def create(self, key, value):
-        ''' create the file '''
+        ''' create a yaml file '''
         if not self.exists():
             self.yaml_dict = {key: value}
             return (True, self.yaml_dict)
@@ -268,13 +276,16 @@ def main():
 
         if rval:
             rval = yamlfile.put(module.params['key'], value)
+            if rval[0]:
+                yamlfile.write()
             module.exit_json(changed=rval[0], results=rval[1], state="present")
 
         if not module.params['content']:
             rval = yamlfile.create(module.params['key'], value)
         else:
-            yamlfile.write()
             rval = yamlfile.load()
+        yamlfile.write()
+
         module.exit_json(changed=rval[0], results=rval[1], state="present")
 
     module.exit_json(failed=True,
-- 
cgit v1.2.3