From 3912fa895a2cd205cf7410e9c54f7b04dc9d9945 Mon Sep 17 00:00:00 2001 From: Rodolfo Carvalho Date: Fri, 9 Jun 2017 14:28:36 +0200 Subject: Consider previous value of 'changed' when updating This avoids unintentionally overriding the value from `True` to `False`. --- roles/openshift_health_checker/openshift_checks/docker_storage.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/openshift_health_checker/openshift_checks/docker_storage.py b/roles/openshift_health_checker/openshift_checks/docker_storage.py index 5c9bed97e..7f1751b36 100644 --- a/roles/openshift_health_checker/openshift_checks/docker_storage.py +++ b/roles/openshift_health_checker/openshift_checks/docker_storage.py @@ -64,7 +64,7 @@ class DockerStorage(DockerHostMixin, OpenShiftCheck): ) return {"failed": True, "changed": changed, "msg": msg} result = self._check_dm_usage(driver_status, task_vars) - result["changed"] = changed + result['changed'] = result.get('changed', False) or changed return result # TODO(lmeyer): determine how to check usage for overlay2 -- cgit v1.2.3