| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
As of Ansible 2.4 this option exists:
https://github.com/ansible/ansible/issues/15035#issuecomment-329672168
The kind of error you get later when this is your real problem tends to be
*very* confusing. Much better to just fail right away.
|
|\
| |
| |
| |
| | |
Automatic merge from submit-queue.
preserve the oo-install ansible_inventory_path value
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, openshift-ansible supported various
types of deployments using the variable "openshift_deployment_type"
Currently, openshift-ansible only supports two deployment types,
"origin" and "openshift-enterprise".
This commit removes all logic and references to deprecated
deployment types.
|
| |
| |
| |
| | |
Previous installer release v3.5 used to display the 3 variants.
I keep OSE as the default, but proposes to add back the "origin v3.6" variant.
|
| |
| |
| |
| |
| |
| | |
Fixes bugzilla : https://bugzilla.redhat.com/show_bug.cgi?id=1460353
Signed-off-by: jkaurredhat <jkaur@redhat.com>
|
|\ \
| | |
| | | |
Fix BZ#1422541 BZ#1440586 BZ#1440612 BZ#1440617 on master branch
|
| | | |
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
AWS hosts and user names frequently make the default Ansible ControlPath
too long. This prevents ssh persistent connections, significantly
impacting runtime. More detail: https://github.com/ansible/ansible/issues/11536
This config change shortens the ControlPath to make this less likely. It
would be better to change it to the %C hash, as extremely long hostnames
or usernames could still encounter this problem, but that is not yet
available with RHEL's openssh. This at least improves the situation.
|
| |
| |
| |
| | |
Fixes bug 1447204
|
| | |
|
|/ |
|
|\
| |
| | |
Consolidate root/utils tests
|
| | |
|
| |
| |
| |
| | |
- Consolidate tests between the root of the repo and utils
|
|/ |
|
| |
|
|
|
|
|
|
|
| |
Instead of checking if a string is True, check if 'found' is True, the
string is the error message.
Also, we can remove the loop and use the simpler Python 'in' construct.
|
|
|
|
|
|
|
|
|
| |
- Do not use `print` in unit tests, send messages through the test
framework instead.
- Remove unused import.
- Add spaces around equal sign in assigment.
- Turn method into a function.
- Reorganize imports according to PEP8.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Fixes issues dumping various objects to YAML. This change updates the
quick installer fact caching callback to use the improved
AnsibleDumper when writing out the facts to storage.
* https://bugzilla.redhat.com/show_bug.cgi?id=1421053
* https://bugzilla.redhat.com/show_bug.cgi?id=1421061
* https://bugzilla.redhat.com/show_bug.cgi?id=1421059
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The `setup_requires` line prevents builds in internal environments
without Internet access / pythonX-pytest-runner RPM installed.
In fact, we're running tests with `pytest`, outside of `setup.py`, so we
don't need those dependencies there.
Note: we decided not to run tests through `python setup.py pytest`
because pytest-runner was limited in how we can pass arguments to pytest
/ enable plugins. E.g., I could not get the coverage plugin working when
running `python setup.py pytest`.
|
| |
|
|
|
|
|
|
| |
Example:
tox -e py35-ansible22-unit -- --collect-only
|
| |
|
|
|
|
| |
Remove old way of running tests, plus mirror edits.
|
|
|
|
|
| |
Found using `vulture`, confirmed that code that was once used became
unused in later commits after its introduction.
|
|
|
|
| |
3.5 added and 3.4 moved to LEGACY
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move pylint tests to tox
- Move yamllint tests to tox
- Create separate tox config (and setup.py) for root
- bump ansible requirement
- unify pylint config
- add docs
- remove git directory containing old testing tools
- install python-six if not present for openshift-facts
- add python-six as a dependency for openshift-ansible-utils
|
| |
|
|\
| |
| | |
The scaleup subcommand does not support the unattended option
|
| |
| |
| |
| |
| |
| | |
* 'atomic-openshift-installer' will exit now if -u is given with the
'scaleup' subcommand
* https://bugzilla.redhat.com/show_bug.cgi?id=1390135
|
|\ \
| |/
|/| |
Update aoi manpage with correct operation count
|
| | |
|
| | |
|
|/
|
|
|
|
|
| |
* Don't print words when checking for sudo access
* Just 'echo' an empty string with no new-line
Closes #3003
|
|
|
|
| |
versions
|
|
|
|
|
| |
* Added checks to make ci for yaml linting
* Modified y(a)ml files to pass lint checks
|
|
|
|
| |
all ci-* targets
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fixed: A grep filter was capturing the actual pylint check rc's
* Changed: pylint used to print out messages for locally-disabled and
file-ignored items
* Changed: pylint output format is now 'parseable'
* Cleaned up: Pylint was emitting deprecation messages for
'required-attributes' and 'ignore-iface-methods'. They have been
removed from the pylintrc file
|
|
|
|
|
|
|
| |
* Adds '--cover-erase' flag to the 'ci-unittests' target
Fixes bug introduced in d7b4265f329591817bac381e2772ae14ac337cea:
"Can't add arcs to existing line data" error message
|
|\
| |
| | |
Speed up 'make ci' and trim the output
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The virtualenv is conditionally rebuilt now if the test requirements
file is modified. This will save upwards of 30+ seconds in iterative
'make ci' runs.
The pylint output is now trimmed to exclude disabled tests.
The order of the 'ci' target prerequisites has been changed to run the
fastest tests first.
Closes #2933
|