| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|\
| |
| | |
Move more plugins to lib_utils
|
| |
| |
| |
| |
| |
| |
| | |
This commit continues moving plugins into lib_utils.
This commit does not move any plugins for add-on roles
such as logging and metrics.
|
|\ \
| |/
|/| |
failure_summary: make sure msg is always a string
|
| |
| |
| |
| |
| |
| | |
Some tasks may return a dict in the msg. In that case `stringc` will
fail to colorize it (with "AttributeError: <msg type> object has no
attribute 'split'" error.
|
|/
|
|
|
|
|
|
|
|
| |
This commit ensures that oreg_url is properly templated
by ansible before being consumed in the logic.
This commit also adds a method to the base health check
class to detect if self._templar is none, and return
the appropriate templated/untemplated version of the
variable. This is mostly for unit tests.
|
|
|
|
|
| |
We set these variables using facts in init, no need
to duplicate the logic all around the codebase.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit relocates filter_plugings to lib_utils,
changes the namespacing to prevent unintended use of
older versions that may be present in filter_plugins/
directory on existing installs.
Add lib_utils to meta depends for roles
Also consolidate some plugins into lib_utils from
various other areas.
Update rpm spec, obsolete plugin rpms.
|
| |
|
|
|
|
|
|
|
|
| |
This commit removes openshift.common.service_type
in favor of openshift_service_type.
This commit also removes r_openshift_excluder_service_type
from plays in favor of using the role's defaults.
|
|
|
|
|
| |
enable option to configure basename in image
docker_image_availability check: follow registry-console image options
|
|\
| |
| | |
reconcile registry-console and docker_image_availability
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes bug 1497310
https://bugzilla.redhat.com/show_bug.cgi?id=1497310
The registry console is a special case in more than one way. This adds
logic to incorporate the openshift_cockpit_deployer_* variables into
determining what its image will be in docker_image_availability.
Along the way I noticed the origin and enterprise templates for this
were not consistent. Now they are, and the example hosts file is updated.
|
|/
|
|
|
|
|
|
|
| |
Update the ovs_version check with the allowed Open vSwitch versions for OCP
3.7.
Add OVS 2.8 to the allowed versions for OCP 3.6 as well.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1509163
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
Automatic merge from submit-queue.
disk_availability check: include submount storage
Fixes bug [1491566](https://bugzilla.redhat.com/show_bug.cgi?id=1491566)
In order to determine how much storage is under a path, include any mounts that are below it in addition to the path itself.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes bug 1491566
https://bugzilla.redhat.com/show_bug.cgi?id=1491566
In order to determine how much storage is under a path, include any
mounts that are below it in addition to the path itself.
|
|\ \
| | |
| | | |
1504593 Refactor health check playbooks
|
| |/
| |
| |
| |
| |
| | |
- Standardize play/tasks naming
- Move install checks to separate playbook with checkpointing
- Correct 'docker_storage' tags
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, docker_image_availability.py plugin check is
using the raw strings for variables from task_vars.
This results in any variables that utilized within the
plugin to be un-templated. For instance, if variable
"x" is set to "{{ y }}" and y is set to "2", one
would expect that x == 2 inside the plugin. Currently,
the plugin will use the string "{{ y }}" for the value
of x instead of templating the variable.
This commit ensures skopeo registry auth credentials
are templated properly.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1500698
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, docker_image_availability health_check
does not support authenticated registries.
This commit adds the '--creds=' option to skopeo
if needed to support authentication credentials.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1316341
Some other fixes to handle docker config better:
Should now account properly for blocked registries, insecure registries,
multiple additional registries, and oreg_url registry with or without credentials.
Output on failure should be clearer about what was tried.
Fixed a bug in the action_plugin_test exposed by these changes.
|
|
|
|
|
| |
fixes bug 1496760
https://bugzilla.redhat.com/show_bug.cgi?id=1496760
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
docker_image_availability casted openshift_docker_additional_registries
to a list using the list() function. If a string was returned (IE: only
a single registry added) the result would be the string split up by
component characters. This change forces a string result from get_var to
be placed inside a list. If the result is anything BUT a string the
original list() function is called on the result.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1497274
Signed-off-by: Steve Milner <smilner@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the enterprise registry to forcefully added
in openshift_facts. Recently, the docker role has
been modified to consume registry variables directly,
bypassing openshift_facts.
This commit cleans up unused code in openshift_facts,
and migrates enterprise registry logic to the
docker role.
Fixes: https://github.com/openshift/openshift-ansible/issues/5557
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
Automatic merge from submit-queue
health checks: add diagnostics check
Adds a health check that runs `oc adm diagnostics` with each individual diagnostic.
Also, moved `is_first_master` method into superclass for reuse. And look at `oo_first_master` and `ansible_host` instead of `masters` and `ansible_ssh_host`.
|
| |
| |
| |
| |
| |
| | |
Also, moved is_first_master method into superclass for reuse. And look
at oo_first_master and ansible_host instead of masters and
ansible_ssh_host.
|
|/
|
|
|
|
|
|
|
|
|
| |
Previously, openshift-ansible supported various
types of deployments using the variable "openshift_deployment_type"
Currently, openshift-ansible only supports two deployment types,
"origin" and "openshift-enterprise".
This commit removes all logic and references to deprecated
deployment types.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some refactoring of checks and the action plugin to enable writing files
locally about the check operation and results, if the user wants them.
This is aimed at enabling persistent and machine-readable results from
recurring runs of health checks.
Now, rather than trying to build a result hash to return from running
each check, checks can just register what they need to as they're going
along, and the action plugin processes state when the check is done.
Checks can register failures, notes about what they saw, and arbitrary
files to be saved into a directory structure where the user specifies.
If no directory is specified, no files are written.
At this time checks can still return a result hash, but that will likely
be refactored away in the next iteration.
Multiple failures can be registered without halting check execution.
Throwing an exception or returning a hash with "failed" is registered as
a failure.
execute_module now does a little more with the results. Results are
automatically included in notes and written individually as files.
"changed" results are propagated. Some json results are decoded.
A few of the checks were enhanced to use these features; all get some of
the features for free.
|
|\
| |
| | |
Merged by openshift-bot
|
| |
| |
| |
| |
| |
| |
| |
| | |
Can now set openshift_disable_check=* to disable all checks without
needing to know their names.
fixes bug 1462106
https://bugzilla.redhat.com/show_bug.cgi?id=1462106
|
| |
| |
| |
| |
| |
| | |
An image in the docker index may be tagged by name or by registry plus
name. In order to find the image correctly locally and prevent looking
for it externally, make sure all possible variations are searched.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Probe whether the host has connectivity to the registry before trying to
inspect it for images, and remember the result. Also if later inspection
fails due to timeout, mark registry as unreachable. Note in failure
output if any registries were unreachable.
Registry order should match what is configured into docker now as well.
Fixes bug 1480195
https://bugzilla.redhat.com/show_bug.cgi?id=1480195
|
| | |
|
|/
|
|
|
|
| |
This makes the callback plugin behave better when dedup is not possible:
work with the original list of failures instead of raising an unhandled
exception and producing confusing output for users.
|
|\
| |
| | |
Merged by openshift-bot
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Tweaks to the logic around using yum vs dnf; now uses ansible_pkg_mgr to
determine which is in effect for a host.
Also, extended the yum logic to check installed packages in addition to
available packages in the aos_version module so that disconnected
installs and others with weird repo configs need not disable the
package_version check.
|
|/ |
|
|\
| |
| |
| |
| | |
Miciah/openshift_checks-ignore-hidden-files-in-checks-directory
openshift_checks: ignore hidden files in checks dir
|
| |
| |
| |
| | |
load_checks: Ignore hidden files when scanning the directory for checks.
|
|\ \
| | |
| | | |
disk_availability: fix bug where msg is overwritten
|
| | | |
|
|\ \ \
| | | |
| | | | |
docker_image_availability: timeout skopeo inspect
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Set a 10 second timeout when using skopeo to inspect remote registries,
so that it does not wait for a tcp timeout to fail if they are unreachable.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
And beautify the code a bit.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This serves two purposes:
- Gracefully omit the summary if there was an error computing it, no
confusion to the regular end user.
- Provide a stacktrace of the error when running verbose, giving
developers or users reporting bugs a better insight of what went wrong,
as opposed to Ansible's opaque handling of errors in callback plugins.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
The intent is to deduplicate similar errors that happened in many hosts,
making the summary more concise.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This prevents an exception in one check from interfering with other
checks. Skips checks that raise an exception in their is_active method.
Whenever capturing a broad exception in the `is_action` or `run`
methods, include traceback information that can be useful in bug
reports.
|