| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
openshift_checks: enable variable conversion
|
| | |
|
|\ \
| | |
| | | |
Merged by openshift-bot
|
| | | |
|
|\ \ \
| |/ /
|/| | |
openshift_checks: refactor check results
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Turn failure messages into exceptions that tests can look for without
depending on text meant for humans.
Turn logging_namespace property into a method.
Get rid of _exec_oc and just use logging.exec_oc.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Introduced the 'changed' property for checks that can make changes to
track whether they did or not. Rather than the check's own logic having
to track this and include it in the result hash, just set the property
and have the action plugin insert it in the result hash after running
(even if there is an exception).
Cleared out a lot of crufty "changed: false" hash entries.
|
|\ \ \
| | | |
| | | | |
Reduce openshift_facts dependencies.
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
juanvallejo/jvallejo/verify-disk-memory-before-upgrade-no-flake
Merged by openshift-bot
|
| | |/
| |/| |
|
|\ \ \
| |_|/
|/| | |
Merged by openshift-bot
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Addresses issue https://github.com/openshift/openshift-ansible/issues/4967
For now, any version >= 3.6 is handled as if it were 3.6. We may want to
keep that or fine-tune it later.
Also, the ovs_version check is not updated. This is a post-install
health check (does not block install/upgrade) with an update already in
progress so will be addressed there.
|
|/ |
|
|
|
|
|
|
|
|
|
| |
This allows users to pass either a string with comma-separated check
names or a proper list of strings, whatever is more convenient in the
context.
For consistency, the same normalization is applied to the
'openshift_disable_check' variable.
|
|
|
|
|
|
| |
The run method is expected to return a dict. Even though we should not
run LoggingCheck by itself, it is still possible to do it and without
this change we get an unhandled exception.
|
|
|
|
|
|
|
|
|
| |
Move task_vars into instance variable so we don't have to pass it
around everywhere. Also store tmp. Make sure both are filled in on
execute_module.
In the process, is_active became an instance method, and task_vars is
basically never used directly outside of test code.
|
| |
|
| |
|
|\
| |
| | |
verify sane log times in logging stack
|
| |
| |
| |
| |
| | |
This patch verifies that logs sent from logging pods can be queried on
the Elasticsearch pod within a reasonable amount of time.
|
|\ \
| | |
| | |
| | |
| | | |
juanvallejo/jvallejo/add-increased-etcd-traffic-check
add check to detect increased etcd traffic
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
fix bug 1469197
https://bugzilla.redhat.com/show_bug.cgi?id=1469197
When Docker is configured with the overlay or overlay2 storage driver,
check that it is supported and usage is below threshold.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Change the package_version check to tolerate either Open vSwitch 2.6 or
2.7.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1465882
This commit removes a unit test that adds no coverage and tests data
instead of logic. This coupling makes every change to supported versions
require the same changes to the tests.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Some packages are supported at more than one major.minor version at the
same time.
Support is added keeping backward compatibility: the 'version' key can
be either a string (single version) or a list of versions.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Split positive and negative tests into their own functions.
This means less lines of code, clearer purpose, easier to understand
what each test does or doesn't and to add new test cases.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In the past, health checks were implemented with ignore_errors: True in
the playbook level, requiring us to store all failures, ignored or not,
so that we could report on all failed checks.
Now checks are run from a single action plugin entry point, without
ignoring errors (all errors are aggregated via the action plugin).
Since the integration of the openshift_health_checker role with the
install playbook, failure summaries are part of the output of a lot more
calls to ansible-playbook. We shall report only failures that caused the
execution to stop, as ignored failures in the summary only serve to
confuse users.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1467809
As a next step, we can refine under which conditions the overlay driver
is supported.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix where execute_module was being passed task_vars in place of tmp
param. Most modules don't seem to use either and so this doesn't fail;
but under some conditions (perhaps different per version of ansible?) it
tried to treat the dict as a string and came back with a python stack
trace.
|
|\ \ \
| | | |
| | | | |
Merged by openshift-bot
|
| | |/
| |/|
| | |
| | | |
fixes bug 1466622 - docker_image_availability check on etcd host failed for 'openshift_image_tag' is undefined
|
|\ \ \
| | | |
| | | | |
Merged by openshift-bot
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
fix bug 1464974 https://bugzilla.redhat.com/show_bug.cgi?id=1464974
Specify --units on vgs call. In my testing with lvm 2.0.2.171(2) on
RHEL Atomic Host 7.4, this turned a response of "<4.07g" into "4.07g"
which should resolve the issue. I haven't found what the "<" is for
in the first place but I'm thinking this should at least be a safe
change.
|
|\ \ \
| | | |
| | | | |
Merged by openshift-bot
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
Calling the action plugin (e.g. when running a playbook) with an
incorrect check name was raising an unhandled exception, leading to poor
output in Ansible (requiring a higher verbosity level to see what is
going wrong).
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
According to the docs the disk requirements should be similar to
non-containerized installs.
https://docs.openshift.org/latest/install_config/install/rpm_vs_containerized.html#containerized-storage-requirements
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
During install, those paths are used and require some free space.
|
|/ /
| |
| |
| | |
Prepare the check to support verifying multiple paths, not only /var.
|
| |
| |
| |
| |
| |
| |
| | |
Some registries are not configured with valid certificates and thus the
check fails with 'http: server gave HTTP response to HTTPS client'.
Since this is not fetching images, but only checking for existence,
trade security for convenience.
|
| |
| |
| |
| |
| |
| |
| |
| | |
The package name has changed.
See
https://bugzilla.redhat.com/show_bug.cgi?id=1461689
https://bugzilla.redhat.com/show_bug.cgi?id=1419718
|
|/
|
|
|
|
|
|
|
|
|
|
| |
Add the docker and RPM checks to the list that run at install time.
They can be disabled the same as the existing ones.
Removed cockpit-kubernetes RPM requirement as it no longer is.
Fixed up docker_image_availability to handle oreg_url and other nuances.
Switched to using the openshift_image_tag that's set by openshift_version for
both component and infrastructure images.
Fixed a bug where execute_module was being called with incorrect
positional arg "tmp" as a dict which caused errors down the call stack.
|
|\
| |
| | |
Merged by openshift-bot
|
| |
| |
| | |
This avoids unintentionally overriding the value from `True` to `False`.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Incorporated docker_storage_driver into docker_storage as both need
driver info.
Corrected storage calculation to include VG free space, not just the
current amount in the LV pool. Now makes no assumptions about pool name.
Improved user messaging.
Factored out some methods that can be shared with docker_image_availability.
|
| | |
|