summaryrefslogtreecommitdiffstats
path: root/roles/openshift_health_checker/test/action_plugin_test.py
Commit message (Collapse)AuthorAgeFilesLines
* openshift_checks: add property to track 'changed'Luke Meyer2017-08-021-5/+9
| | | | | | | | | | Introduced the 'changed' property for checks that can make changes to track whether they did or not. Rather than the check's own logic having to track this and include it in the result hash, just set the property and have the action plugin insert it in the result hash after running (even if there is an exception). Cleared out a lot of crufty "changed: false" hash entries.
* openshift_checks: refactor to internalize task_varsLuke Meyer2017-07-251-9/+8
| | | | | | | | | Move task_vars into instance variable so we don't have to pass it around everywhere. Also store tmp. Make sure both are filled in on execute_module. In the process, is_active became an instance method, and task_vars is basically never used directly outside of test code.
* Capture exceptions when resolving available checksRodolfo Carvalho2017-06-231-1/+11
| | | | | | | Calling the action plugin (e.g. when running a playbook) with an incorrect check name was raising an unhandled exception, leading to poor output in Ansible (requiring a higher verbosity level to see what is going wrong).
* health checks: specify check skip reasonLuke Meyer2017-05-231-1/+15
| | | | | Added indicator to check result for why that check was skipped. Note that currently the user will only see it with ansible-playbook -vv
* Fix instantiation of action plugin in test fixtureRodolfo Carvalho2017-04-131-1/+3
| | | | | | | | In Ansible 2.3+, the base action plugin class' run method depends on accessing attributes (check_mode) of its play_context. In older versions play_context was not involved in run, and thus None was passed in.
* Add tests for action pluginRodolfo Carvalho2017-04-041-15/+168
|
* Make resolve_checks more strictRodolfo Carvalho2017-04-041-0/+74
So that all names it return are directly usable, without checking for existence.