| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Introduced the 'changed' property for checks that can make changes to
track whether they did or not. Rather than the check's own logic having
to track this and include it in the result hash, just set the property
and have the action plugin insert it in the result hash after running
(even if there is an exception).
Cleared out a lot of crufty "changed: false" hash entries.
|
| |
|
|
|
|
|
|
|
|
|
| |
Move task_vars into instance variable so we don't have to pass it
around everywhere. Also store tmp. Make sure both are filled in on
execute_module.
In the process, is_active became an instance method, and task_vars is
basically never used directly outside of test code.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
It is a function/callable, the name should imply action, should be a
verb and not a noun.
Keep supporting the old name while we have PRs in-flight that use the
old name.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out the code in
roles/openshift_health_checker/openshift_checks/__init__.py had a
mistake in the import statement, and not the case that `add_metaclass`
is not available in the embedded `six` from `ansible.module_utils`.
The fix is to correct the import and do not require python-six to be
installed on target hosts.
Note: now that we have some unit tests in the role, errors like that
would have been caught.
|
| |
|
|
|
|
|
| |
Embedded version of six in Ansible 2.2.1 does not support add_metaclass,
so revert to using python-six.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
This allows us to refer to a group of checks using a single handle.
|
|
This approach should make it easier to add new checks without having to
write lots of YAML and doing things against Ansible (e.g.
ignore_errors).
A single action plugin determines what checks to run per each host,
including arguments to the check. A check is implemented as a class with
a run method, with the same signature as an action plugin and module,
and is normally backed by a regular Ansible module.
Each check is implemented as a separate Python file. This allows whoever
adds a new check to focus solely in a single Python module, and
potentially an Ansible module within library/ too.
All checks are automatically loaded, and only active checks that are
requested by the playbook get executed.
|