1 files changed, 116 insertions, 0 deletions
diff --git a/roles/openshift_health_checker/test/package_version_test.py b/roles/openshift_health_checker/test/package_version_test.py
new file mode 100644
index 000000000..3cf4ce033
--- /dev/null
+++ b/roles/openshift_health_checker/test/package_version_test.py
@@ -0,0 +1,116 @@
+import pytest
+
+from openshift_checks.package_version import PackageVersion, OpenShiftCheckException
+
+
+def task_vars_for(openshift_release, deployment_type):
+    return dict(
+        ansible_pkg_mgr='yum',
+        openshift=dict(common=dict(service_type=deployment_type)),
+        openshift_release=openshift_release,
+        openshift_image_tag='v' + openshift_release,
+        openshift_deployment_type=deployment_type,
+    )
+
+
+def test_openshift_version_not_supported():
+    check = PackageVersion(None, task_vars_for("1.2.3", 'origin'))
+    check.get_openshift_version_tuple = lambda: (3, 4, 1)  # won't be in the dict
+
+    with pytest.raises(OpenShiftCheckException) as excinfo:
+        check.get_required_ovs_version()
+    assert "no recommended version of Open vSwitch" in str(excinfo.value)
+
+    with pytest.raises(OpenShiftCheckException) as excinfo:
+        check.get_required_docker_version()
+    assert "no recommended version of Docker" in str(excinfo.value)
+
+
+def test_invalid_openshift_release_format():
+    task_vars = dict(
+        ansible_pkg_mgr='yum',
+        openshift=dict(common=dict(service_type='origin')),
+        openshift_image_tag='v0',
+        openshift_deployment_type='origin',
+    )
+
+    check = PackageVersion(lambda *_: {}, task_vars)
+    with pytest.raises(OpenShiftCheckException) as excinfo:
+        check.run()
+    assert "invalid version" in str(excinfo.value)
+
+
+@pytest.mark.parametrize('openshift_release', [
+    "111.7.0",
+    "3.7",
+    "3.6",
+    "3.5.1.2.3",
+    "3.5",
+    "3.4",
+    "3.3",
+    "2.1.0",
+])
+def test_package_version(openshift_release):
+
+    return_value = {"foo": object()}
+
+    def execute_module(module_name=None, module_args=None, tmp=None, task_vars=None, *_):
+        assert module_name == 'aos_version'
+        assert "package_list" in module_args
+
+        for pkg in module_args["package_list"]:
+            if "-master" in pkg["name"] or "-node" in pkg["name"]:
+                assert pkg["version"] == task_vars["openshift_release"]
+
+        return return_value
+
+    check = PackageVersion(execute_module, task_vars_for(openshift_release, 'origin'))
+    result = check.run()
+    assert result == return_value
+
+
+@pytest.mark.parametrize('deployment_type,openshift_release,expected_docker_version', [
+    ("origin", "3.5", "1.12"),
+    ("origin", "1.3", "1.10"),
+    ("origin", "1.1", "1.8"),
+    ("openshift-enterprise", "3.4", "1.12"),
+    ("openshift-enterprise", "3.2", "1.10"),
+    ("openshift-enterprise", "3.1", "1.8"),
+])
+def test_docker_package_version(deployment_type, openshift_release, expected_docker_version):
+
+    return_value = {"foo": object()}
+
+    def execute_module(module_name=None, module_args=None, *_):
+        assert module_name == 'aos_version'
+        assert "package_list" in module_args
+
+        for pkg in module_args["package_list"]:
+            if pkg["name"] == "docker":
+                assert pkg["version"] == expected_docker_version
+
+        return return_value
+
+    check = PackageVersion(execute_module, task_vars_for(openshift_release, deployment_type))
+    result = check.run()
+    assert result == return_value
+
+
+@pytest.mark.parametrize('group_names,is_containerized,is_active', [
+    (['oo_masters_to_config'], False, True),
+    # ensure check is skipped on containerized installs
+    (['oo_masters_to_config'], True, False),
+    (['oo_nodes_to_config'], False, True),
+    (['oo_masters_to_config', 'oo_nodes_to_config'], False, True),
+    (['oo_masters_to_config', 'oo_etcd_to_config'], False, True),
+    ([], False, False),
+    (['oo_etcd_to_config'], False, False),
+    (['lb'], False, False),
+    (['nfs'], False, False),
+])
+def test_package_version_skip_when_not_master_nor_node(group_names, is_containerized, is_active):
+    task_vars = dict(
+        group_names=group_names,
+        openshift=dict(common=dict(is_containerized=is_containerized)),
+    )
+    assert PackageVersion(None, task_vars).is_active() == is_active