diff options
Diffstat (limited to 'playbooks/gce')
| -rw-r--r-- | playbooks/gce/openshift-cluster/config.yml | 37 | ||||
| -rw-r--r-- | playbooks/gce/openshift-cluster/launch.yml | 72 | ||||
| -rw-r--r-- | playbooks/gce/openshift-cluster/list.yml | 15 | ||||
| -rw-r--r-- | playbooks/gce/openshift-cluster/tasks/launch_instances.yml (renamed from playbooks/gce/openshift-cluster/launch_instances.yml) | 26 | ||||
| -rw-r--r-- | playbooks/gce/openshift-cluster/terminate.yml | 22 | ||||
| -rw-r--r-- | playbooks/gce/openshift-cluster/update.yml | 25 | ||||
| -rw-r--r-- | playbooks/gce/openshift-cluster/vars.yml | 14 | ||||
| -rw-r--r-- | playbooks/gce/openshift-master/config.yml | 24 | ||||
| -rw-r--r-- | playbooks/gce/openshift-master/launch.yml | 6 | ||||
| -rw-r--r-- | playbooks/gce/openshift-master/terminate.yml | 11 | ||||
| -rw-r--r-- | playbooks/gce/openshift-master/vars.yml | 3 | ||||
| -rw-r--r-- | playbooks/gce/openshift-node/config.yml | 106 | ||||
| -rw-r--r-- | playbooks/gce/openshift-node/launch.yml | 6 | ||||
| -rw-r--r-- | playbooks/gce/openshift-node/terminate.yml | 11 | ||||
| -rw-r--r-- | playbooks/gce/openshift-node/vars.yml | 3 | 
15 files changed, 166 insertions, 215 deletions
diff --git a/playbooks/gce/openshift-cluster/config.yml b/playbooks/gce/openshift-cluster/config.yml new file mode 100644 index 000000000..8b8490246 --- /dev/null +++ b/playbooks/gce/openshift-cluster/config.yml @@ -0,0 +1,37 @@ +--- +# TODO: fix firewall related bug with GCE and origin, since GCE is overriding +# /etc/sysconfig/iptables +- name: Populate oo_masters_to_config host group +  hosts: localhost +  gather_facts: no +  vars_files: +  - vars.yml +  tasks: +  - name: Evaluate oo_masters_to_config +    add_host: +      name: "{{ item }}" +      groups: oo_masters_to_config +      ansible_ssh_user: "{{ deployment_vars[deployment_type].ssh_user | default(ansible_ssh_user, true) }}" +      ansible_sudo: "{{ deployment_vars[deployment_type].sudo }}" +    with_items: groups["tag_env-host-type-{{ cluster_id }}-openshift-master"] | default([]) +  - name: Evaluate oo_nodes_to_config +    add_host: +      name: "{{ item }}" +      groups: oo_nodes_to_config +      ansible_ssh_user: "{{ deployment_vars[deployment_type].ssh_user | default(ansible_ssh_user, true) }}" +      ansible_sudo: "{{ deployment_vars[deployment_type].sudo }}" +    with_items: groups["tag_env-host-type-{{ cluster_id }}-openshift-node"] | default([]) +  - name: Evaluate oo_first_master +    add_host: +      name: "{{ groups['tag_env-host-type-' ~ cluster_id ~ '-openshift-master'][0] }}" +      groups: oo_first_master +      ansible_ssh_user: "{{ deployment_vars[deployment_type].ssh_user | default(ansible_ssh_user, true) }}" +      ansible_sudo: "{{ deployment_vars[deployment_type].sudo }}" +    when: "'tag_env-host-type-{{ cluster_id }}-openshift-master' in groups" + +- include: ../../common/openshift-cluster/config.yml +  vars: +    openshift_cluster_id: "{{ cluster_id }}" +    openshift_debug_level: 4 +    openshift_deployment_type: "{{ deployment_type }}" +    openshift_hostname: "{{ gce_private_ip }}" diff --git a/playbooks/gce/openshift-cluster/launch.yml b/playbooks/gce/openshift-cluster/launch.yml index 14cdd2537..34a5a0b94 100644 --- a/playbooks/gce/openshift-cluster/launch.yml +++ b/playbooks/gce/openshift-cluster/launch.yml @@ -4,59 +4,25 @@    connection: local    gather_facts: no    vars_files: -      - vars.yml +  - vars.yml    tasks: -    - set_fact: k8s_type="master" - -    - name: Generate master instance names(s) -      set_fact: scratch={{ cluster_id }}-{{ k8s_type }}-{{ '%05x' |format( 1048576 |random) }} -      register: master_names_output -      with_sequence: start=1 end={{ num_masters }} - -    # These set_fact's cannot be combined -    - set_fact: -        master_names_string: "{% for item in master_names_output.results %}{{ item.ansible_facts.scratch }} {% endfor %}" - -    - set_fact: -        master_names: "{{ master_names_string.strip().split(' ') }}" - -    - include: launch_instances.yml -      vars: -        instances: "{{ master_names }}" -        cluster: "{{ cluster_id }}" -        type: "{{ k8s_type }}" - -    - set_fact: k8s_type="node" - -    - name: Generate node instance names(s) -      set_fact: scratch={{ cluster_id }}-{{ k8s_type }}-{{ '%05x' |format( 1048576 |random) }} -      register: node_names_output -      with_sequence: start=1 end={{ num_nodes }} - -    # These set_fact's cannot be combined -    - set_fact: -        node_names_string: "{% for item in node_names_output.results %}{{ item.ansible_facts.scratch }} {% endfor %}" - -    - set_fact: -        node_names: "{{ node_names_string.strip().split(' ') }}" - -    - include: launch_instances.yml -      vars: -        instances: "{{ node_names }}" -        cluster: "{{ cluster_id }}" -        type: "{{ k8s_type }}" - -- hosts: "tag_env-{{ cluster_id }}" -  roles: -  - openshift_repos -  - os_update_latest - -- include: ../openshift-master/config.yml -  vars: -    oo_host_group_exp: "groups[\"tag_env-host-type-{{ cluster_id }}-openshift-master\"]" - -- include: ../openshift-node/config.yml -  vars: -    oo_host_group_exp: "groups[\"tag_env-host-type-{{ cluster_id }}-openshift-node\"]" +  - fail: msg="Deployment type not supported for libvirt provider yet" +    when: deployment_type == 'enterprise' + +  - include: ../../common/openshift-cluster/set_master_launch_facts_tasks.yml +  - include: tasks/launch_instances.yml +    vars: +      instances: "{{ master_names }}" +      cluster: "{{ cluster_id }}" +      type: "{{ k8s_type }}" + +  - include: ../../common/openshift-cluster/set_node_launch_facts_tasks.yml +  - include: tasks/launch_instances.yml +    vars: +      instances: "{{ node_names }}" +      cluster: "{{ cluster_id }}" +      type: "{{ k8s_type }}" + +- include: update.yml  - include: list.yml diff --git a/playbooks/gce/openshift-cluster/list.yml b/playbooks/gce/openshift-cluster/list.yml index 1124b0ea3..bab2fb9f8 100644 --- a/playbooks/gce/openshift-cluster/list.yml +++ b/playbooks/gce/openshift-cluster/list.yml @@ -2,16 +2,23 @@  - name: Generate oo_list_hosts group    hosts: localhost    gather_facts: no +  vars_files: +  - vars.yml    tasks:    - set_fact: scratch_group=tag_env-{{ cluster_id }}      when: cluster_id != ''    - set_fact: scratch_group=all -    when: scratch_group is not defined -  - add_host: name={{ item }} groups=oo_list_hosts -    with_items: groups[scratch_group] | difference(['localhost']) | difference(groups.status_terminated) +    when: cluster_id == '' +  - add_host: +      name: "{{ item }}" +      groups: oo_list_hosts +      ansible_ssh_user: "{{ deployment_vars[deployment_type].ssh_user | default(ansible_ssh_user, true) }}" +      ansible_sudo: "{{ deployment_vars[deployment_type].sudo }}" +    with_items: groups[scratch_group] | default([]) | difference(['localhost']) | difference(groups.status_terminated)  - name: List Hosts    hosts: oo_list_hosts    gather_facts: no    tasks: -  - debug: msg="public:{{hostvars[inventory_hostname].gce_public_ip}} private:{{hostvars[inventory_hostname].gce_private_ip}}" +  - debug: +      msg: "public ip:{{ hostvars[inventory_hostname].gce_public_ip }} private ip:{{ hostvars[inventory_hostname].gce_private_ip }} deployment-type: {{ hostvars[inventory_hostname].group_names | oo_get_deployment_type_from_groups }}" diff --git a/playbooks/gce/openshift-cluster/launch_instances.yml b/playbooks/gce/openshift-cluster/tasks/launch_instances.yml index b4f33bd87..a68edefae 100644 --- a/playbooks/gce/openshift-cluster/launch_instances.yml +++ b/playbooks/gce/openshift-cluster/tasks/launch_instances.yml @@ -2,41 +2,39 @@  # TODO: when we are ready to go to ansible 1.9+ support only, we can update to  # the gce task to use the disk_auto_delete parameter to avoid having to delete  # the disk as a separate step on termination - -- set_fact: -    machine_type: "{{ lookup('env', 'gce_machine_type') |default('n1-standard-1', true) }}" -    machine_image: "{{ lookup('env', 'gce_machine_image') |default('libra-rhel7', true) }}" -  - name: Launch instance(s)    gce:      instance_names: "{{ instances }}" -    machine_type: "{{ machine_type }}" -    image: "{{ machine_image }}" +    machine_type: "{{ lookup('env', 'gce_machine_type') | default('n1-standard-1', true) }}" +    image: "{{ lookup('env', 'gce_machine_image') | default(deployment_vars[deployment_type].image, true) }}"      service_account_email: "{{ lookup('env', 'gce_service_account_email_address') }}"      pem_file: "{{ lookup('env', 'gce_service_account_pem_file_path') }}"      project_id: "{{ lookup('env', 'gce_project_id') }}"      tags: -      - "created-by-{{ lookup('env', 'LOGNAME') |default(cluster, true) }}" -      - "env-{{ cluster }}" -      - "host-type-{{ type }}" -      - "env-host-type-{{ cluster }}-openshift-{{ type }}" +      - created-by-{{ lookup('env', 'LOGNAME') |default(cluster, true) }} +      - env-{{ cluster }} +      - host-type-{{ type }} +      - env-host-type-{{ cluster }}-openshift-{{ type }} +      - deployment-type-{{ deployment_type }}    register: gce  - name: Add new instances to groups and set variables needed    add_host:      hostname: "{{ item.name }}"      ansible_ssh_host: "{{ item.public_ip }}" +    ansible_ssh_user: "{{ deployment_vars[deployment_type].ssh_user | default(ansible_ssh_user, true) }}" +    ansible_sudo: "{{ deployment_vars[deployment_type].sudo }}"      groups: "{{ item.tags | oo_prepend_strings_in_list('tag_') | join(',') }}"      gce_public_ip: "{{ item.public_ip }}"      gce_private_ip: "{{ item.private_ip }}"    with_items: gce.instance_data  - name: Wait for ssh -  wait_for: "port=22 host={{ item.public_ip }}" +  wait_for: port=22 host={{ item.public_ip }}    with_items: gce.instance_data -- name: Wait for root user setup -  command: "ssh -o StrictHostKeyChecking=no -o PasswordAuthentication=no -o ConnectTimeout=10 -o UserKnownHostsFile=/dev/null root@{{ item.public_ip }} echo root user is setup" +- name: Wait for user setup +  command: "ssh -o StrictHostKeyChecking=no -o PasswordAuthentication=no -o ConnectTimeout=10 -o UserKnownHostsFile=/dev/null {{ hostvars[item.name].ansible_ssh_user }}@{{ item.public_ip }} echo {{ hostvars[item.name].ansible_ssh_user }} user is setup"    register: result    until: result.rc == 0    retries: 20 diff --git a/playbooks/gce/openshift-cluster/terminate.yml b/playbooks/gce/openshift-cluster/terminate.yml index 0281ae953..abe6a4c95 100644 --- a/playbooks/gce/openshift-cluster/terminate.yml +++ b/playbooks/gce/openshift-cluster/terminate.yml @@ -1,20 +1,34 @@  ---  - name: Terminate instance(s)    hosts: localhost - +  gather_facts: no    vars_files: -    - vars.yml +  - vars.yml +  tasks: +  - set_fact: scratch_group=tag_env-host-type-{{ cluster_id }}-openshift-node +  - add_host: +      name: "{{ item }}" +      groups: oo_nodes_to_terminate +      ansible_ssh_user: "{{ deployment_vars[deployment_type].ssh_user | default(ansible_ssh_user, true) }}" +      ansible_sudo: "{{ deployment_vars[deployment_type].sudo }}" +    with_items: groups[scratch_group] | default([]) | difference(['localhost']) | difference(groups.status_terminated) + +  - set_fact: scratch_group=tag_env-host-type-{{ cluster_id }}-openshift-master +  - add_host: +      name: "{{ item }}" +      groups: oo_masters_to_terminate +      ansible_ssh_user: "{{ deployment_vars[deployment_type].ssh_user | default(ansible_ssh_user, true) }}" +      ansible_sudo: "{{ deployment_vars[deployment_type].sudo }}" +    with_items: groups[scratch_group] | default([]) | difference(['localhost']) | difference(groups.status_terminated)  - include: ../openshift-node/terminate.yml    vars: -    oo_host_group_exp: 'groups["tag_env-host-type-{{ cluster_id }}-openshift-node"]'      gce_service_account_email: "{{ lookup('env', 'gce_service_account_email_address') }}"      gce_pem_file: "{{ lookup('env', 'gce_service_account_pem_file_path') }}"      gce_project_id: "{{ lookup('env', 'gce_project_id') }}"  - include: ../openshift-master/terminate.yml    vars: -    oo_host_group_exp: 'groups["tag_env-host-type-{{ cluster_id }}-openshift-master"]'      gce_service_account_email: "{{ lookup('env', 'gce_service_account_email_address') }}"      gce_pem_file: "{{ lookup('env', 'gce_service_account_pem_file_path') }}"      gce_project_id: "{{ lookup('env', 'gce_project_id') }}" diff --git a/playbooks/gce/openshift-cluster/update.yml b/playbooks/gce/openshift-cluster/update.yml index 973e4c3ef..9ebf39a13 100644 --- a/playbooks/gce/openshift-cluster/update.yml +++ b/playbooks/gce/openshift-cluster/update.yml @@ -1,13 +1,18 @@  --- -- hosts: "tag_env-{{ cluster_id }}" -  roles: -  - openshift_repos -  - os_update_latest +- name: Populate oo_hosts_to_update group +  hosts: localhost +  gather_facts: no +  vars_files: +  - vars.yml +  tasks: +  - name: Evaluate oo_hosts_to_update +    add_host: +      name: "{{ item }}" +      groups: oo_hosts_to_update +      ansible_ssh_user: "{{ deployment_vars[deployment_type].ssh_user | default(ansible_ssh_user, true) }}" +      ansible_sudo: "{{ deployment_vars[deployment_type].sudo }}" +    with_items: groups["tag_env-host-type-{{ cluster_id }}-openshift-master"] | union(groups["tag_env-host-type-{{ cluster_id }}-openshift-node"]) | default([]) -- include: ../openshift-master/config.yml -  vars: -    oo_host_group_exp: "groups[\"tag_env-host-type-{{ cluster_id }}-openshift-master\"]" +- include: ../../common/openshift-cluster/update_repos_and_packages.yml -- include: ../openshift-node/config.yml -  vars: -    oo_host_group_exp: "groups[\"tag_env-host-type-{{ cluster_id }}-openshift-node\"]" +- include: config.yml diff --git a/playbooks/gce/openshift-cluster/vars.yml b/playbooks/gce/openshift-cluster/vars.yml index ed97d539c..ae33083b9 100644 --- a/playbooks/gce/openshift-cluster/vars.yml +++ b/playbooks/gce/openshift-cluster/vars.yml @@ -1 +1,15 @@  --- +deployment_vars: +  origin: +    image: centos-7 +    ssh_user: +    sudo: yes +  online: +    image: libra-rhel7 +    ssh_user: root +    sudo: no +  enterprise: +    image: rhel-7 +    ssh_user: +    sudo: yes + diff --git a/playbooks/gce/openshift-master/config.yml b/playbooks/gce/openshift-master/config.yml index 857da0763..af6000bc8 100644 --- a/playbooks/gce/openshift-master/config.yml +++ b/playbooks/gce/openshift-master/config.yml @@ -1,20 +1,18 @@  --- -- name: master/config.yml, populate oo_masters_to_config host group if needed +- name: Populate oo_masters_to_config host group    hosts: localhost    gather_facts: no    tasks: -  - name: "Evaluate oo_host_group_exp if it's set" -    add_host: "name={{ item }} groups=oo_masters_to_config" -    with_items: "{{ oo_host_group_exp | default('') }}" -    when: oo_host_group_exp is defined +  - name: Evaluate oo_masters_to_config +    add_host: +      name: "{{ item }}" +      groups: oo_masters_to_config +      ansible_ssh_user: root +    with_items: oo_host_group_exp | default([]) -- name: "Configure instances" -  hosts: oo_masters_to_config +- include: ../../common/openshift-master/config.yml    vars: +    openshift_cluster_id: "{{ cluster_id }}" +    openshift_debug_level: 4 +    openshift_deployment_type: "{{ deployment_type }}"      openshift_hostname: "{{ gce_private_ip }}" -  vars_files: -  - vars.yml -  roles: -    - openshift_master -    - pods -    - os_env_extras diff --git a/playbooks/gce/openshift-master/launch.yml b/playbooks/gce/openshift-master/launch.yml index 287596002..ef10b6cf0 100644 --- a/playbooks/gce/openshift-master/launch.yml +++ b/playbooks/gce/openshift-master/launch.yml @@ -8,14 +8,12 @@    connection: local    gather_facts: no +# TODO: modify image based on deployment_type    vars:      inst_names: "{{ oo_new_inst_names }}"      machine_type: n1-standard-1      image: libra-rhel7 -  vars_files: -      - vars.yml -    tasks:      - name: Launch instances        gce: @@ -37,7 +35,7 @@        with_items: gce.instance_data      - name: Wait for ssh -      wait_for: "port=22 host={{ item.public_ip }}" +      wait_for: port=22 host={{ item.public_ip }}        with_items: gce.instance_data      - name: Wait for root user setup diff --git a/playbooks/gce/openshift-master/terminate.yml b/playbooks/gce/openshift-master/terminate.yml index 8319774f8..452ac5199 100644 --- a/playbooks/gce/openshift-master/terminate.yml +++ b/playbooks/gce/openshift-master/terminate.yml @@ -3,10 +3,9 @@    hosts: localhost    gather_facts: no    tasks: -    - name: Evaluate oo_host_group_exp if it's set -      add_host: "name={{ item }} groups=oo_masters_to_terminate" -      with_items: "{{ oo_host_group_exp | default('') }}" -      when: oo_host_group_exp is defined +    - name: Evaluate oo_masters_to_terminate +      add_host: name={{ item }} groups=oo_masters_to_terminate +      with_items: oo_host_group_exp | default([])  - name: Terminate master instances    hosts: localhost @@ -22,6 +21,7 @@          instance_names: "{{ groups['oo_masters_to_terminate'] }}"          disks: "{{ groups['oo_masters_to_terminate'] }}"        register: gce +      when: "'oo_masters_to_terminate' in groups"      - name: Remove disks of instances        gce_pd: @@ -32,5 +32,4 @@          zone: "{{ gce.zone }}"          state: absent        with_items: gce.instance_names - - +      when: "'oo_masters_to_terminate' in groups" diff --git a/playbooks/gce/openshift-master/vars.yml b/playbooks/gce/openshift-master/vars.yml deleted file mode 100644 index c196b2fca..000000000 --- a/playbooks/gce/openshift-master/vars.yml +++ /dev/null @@ -1,3 +0,0 @@ ---- -openshift_debug_level: 4 -openshift_cluster_id: "{{ cluster_id }}" diff --git a/playbooks/gce/openshift-node/config.yml b/playbooks/gce/openshift-node/config.yml index 771cc3a94..5b1601176 100644 --- a/playbooks/gce/openshift-node/config.yml +++ b/playbooks/gce/openshift-node/config.yml @@ -1,100 +1,24 @@  --- -- name: node/config.yml, populate oo_nodes_to_config host group if needed +- name: Populate oo_nodes_to_config and oo_first_master host groups    hosts: localhost    gather_facts: no    tasks: -  - name: Evaluate oo_host_group_exp -    add_host: "name={{ item }} groups=oo_nodes_to_config" -    with_items: "{{ oo_host_group_exp | default('') }}" -    when: oo_host_group_exp is defined -  - add_host: +  - name: Evaluate oo_nodes_to_config +    add_host: +      name: "{{ item }}" +      groups: oo_nodes_to_config +      ansible_ssh_user: root +    with_items: oo_host_group_exp | default([]) +  - name: Evaluate oo_first_master +    add_host:        name: "{{ groups['tag_env-host-type-' ~ cluster_id ~ '-openshift-master'][0] }}"        groups: oo_first_master -    when: oo_host_group_exp is defined +      ansible_ssh_user: root -- name: Gather and set facts for hosts to configure -  hosts: oo_nodes_to_config -  roles: -  - openshift_facts -  tasks: -  # Since the master is registering the nodes before they are configured, we -  # need to make sure to set the node properties beforehand if we do not want -  # the defaults -  - openshift_facts: -      role: "{{ item.role }}" -      local_facts: "{{ item.local_facts }}" -    with_items: -    - role: common -      local_facts: -        hostname: "{{ gce_private_ip }}" -    - role: node -      local_facts: -        external_id: "{{ openshift_node_external_id | default(None) }}" -        resources_cpu: "{{ openshfit_node_resources_cpu | default(None) }}" -        resources_memory: "{{ openshfit_node_resources_memory | default(None) }}" -        pod_cidr: "{{ openshfit_node_pod_cidr | default(None) }}" -        labels: "{{ openshfit_node_labels | default(None) }}" -        annotations: "{{ openshfit_node_annotations | default(None) }}" - - -- name: Register nodes -  hosts: oo_first_master -  vars: -    openshift_nodes: "{{ hostvars -          | oo_select_keys(groups['oo_nodes_to_config']) }}" -  roles: -  - openshift_register_nodes -  tasks: -  - name: Create local temp directory for syncing certs -    local_action: command /usr/bin/mktemp -d /tmp/openshift-ansible-XXXXXXX -    register: mktemp - -  - name: Sync master certs to localhost -    synchronize: -      mode: pull -      checksum: yes -      src: /var/lib/openshift/openshift.local.certificates -      dest: "{{ mktemp.stdout }}" - -- name: Configure instances -  hosts: oo_nodes_to_config -  vars_files: -  - vars.yml +- include: ../../common/openshift-node/config.yml    vars: -    sync_tmpdir: "{{ hostvars[groups['oo_first_master'][0]].mktemp.stdout }}" -    cert_parent_rel_path: openshift.local.certificates -    cert_rel_path: "{{ cert_parent_rel_path }}/node-{{ openshift.common.hostname }}" -    cert_base_path: /var/lib/openshift -    cert_parent_path: "{{ cert_base_path }}/{{ cert_parent_rel_path }}" -    cert_path: "{{ cert_base_path }}/{{ cert_rel_path }}" -  pre_tasks: -  - name: Ensure certificate directories exists -    file: -      path: "{{ item }}" -      state: directory -    with_items: -    - "{{ cert_path }}" -    - "{{ cert_parent_path }}/ca" - -  # TODO: notify restart openshift-node and/or restart openshift-sdn-node, -  # possibly test service started time against certificate/config file -  # timestamps in openshift-node or openshift-sdn-node to trigger notify -  - name: Sync certs to nodes -    synchronize: -      checksum: yes -      src: "{{ item.src }}" -      dest: "{{ item.dest }}" -      owner: no -      group: no -    with_items: -    - src: "{{ sync_tmpdir }}/{{ cert_rel_path }}" -      dest: "{{ cert_parent_path }}" -    - src: "{{ sync_tmpdir }}/{{ cert_parent_rel_path }}/ca/cert.crt" -      dest: "{{ cert_parent_path }}/ca/cert.crt" -  - local_action: file name={{ sync_tmpdir }} state=absent -    run_once: true -  roles: -    - openshift_node -    - os_env_extras -    - os_env_extras_node +    openshift_cluster_id: "{{ cluster_id }}" +    openshift_debug_level: 4 +    openshift_deployment_type: "{{ deployment_type }}" +    openshift_hostname: "{{ gce_private_ip }}" diff --git a/playbooks/gce/openshift-node/launch.yml b/playbooks/gce/openshift-node/launch.yml index 73d0478ab..086ba58bc 100644 --- a/playbooks/gce/openshift-node/launch.yml +++ b/playbooks/gce/openshift-node/launch.yml @@ -8,14 +8,12 @@    connection: local    gather_facts: no +# TODO: modify image based on deployment_type    vars:      inst_names: "{{ oo_new_inst_names }}"      machine_type: n1-standard-1      image: libra-rhel7 -  vars_files: -      - vars.yml -    tasks:      - name: Launch instances        gce: @@ -37,7 +35,7 @@        with_items: gce.instance_data      - name: Wait for ssh -      wait_for: "port=22 host={{ item.public_ip }}" +      wait_for: port=22 host={{ item.public_ip }}        with_items: gce.instance_data      - name: Wait for root user setup diff --git a/playbooks/gce/openshift-node/terminate.yml b/playbooks/gce/openshift-node/terminate.yml index 7d71dfcab..357e0c295 100644 --- a/playbooks/gce/openshift-node/terminate.yml +++ b/playbooks/gce/openshift-node/terminate.yml @@ -3,10 +3,9 @@    hosts: localhost    gather_facts: no    tasks: -    - name: Evaluate oo_host_group_exp if it's set -      add_host: "name={{ item }} groups=oo_nodes_to_terminate" -      with_items: "{{ oo_host_group_exp | default('') }}" -      when: oo_host_group_exp is defined +    - name: Evaluate oo_nodes_to_terminate +      add_host: name={{ item }} groups=oo_nodes_to_terminate +      with_items: oo_host_group_exp | default([])  - name: Terminate node instances    hosts: localhost @@ -22,6 +21,7 @@          instance_names: "{{ groups['oo_nodes_to_terminate'] }}"          disks: "{{ groups['oo_nodes_to_terminate'] }}"        register: gce +      when: "'oo_nodes_to_terminate' in groups"      - name: Remove disks of instances        gce_pd: @@ -32,5 +32,4 @@          zone: "{{ gce.zone }}"          state: absent        with_items: gce.instance_names - - +      when: "'oo_nodes_to_terminate' in groups" diff --git a/playbooks/gce/openshift-node/vars.yml b/playbooks/gce/openshift-node/vars.yml deleted file mode 100644 index c196b2fca..000000000 --- a/playbooks/gce/openshift-node/vars.yml +++ /dev/null @@ -1,3 +0,0 @@ ---- -openshift_debug_level: 4 -openshift_cluster_id: "{{ cluster_id }}"  | 
