diff options
| author | Scott Dodson <sdodson@redhat.com> | 2017-02-14 13:52:08 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-02-14 13:52:08 -0500 |
| commit | dcbc04be7d1f621d1cf95168c8d1265279d04ed1 (patch) | |
| tree | b5ceb3d12b098c75817e2984dc3417929ca24ad1 /roles/openshift_manageiq/tasks | |
| parent | b61593976cedf3946ede5b6c5cc9bd80b0747cf3 (diff) | |
| parent | 0b1c1c2c524bfb932ab0e15f63f464673c00e651 (diff) | |
| download | openshift-dcbc04be7d1f621d1cf95168c8d1265279d04ed1.tar.gz openshift-dcbc04be7d1f621d1cf95168c8d1265279d04ed1.tar.bz2 openshift-dcbc04be7d1f621d1cf95168c8d1265279d04ed1.tar.xz openshift-dcbc04be7d1f621d1cf95168c8d1265279d04ed1.zip | |
Merge pull request #3355 from tbielawa/idempotency_please_work
Idempotency please work
Diffstat (limited to 'roles/openshift_manageiq/tasks')
| -rw-r--r-- | roles/openshift_manageiq/tasks/main.yaml | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/roles/openshift_manageiq/tasks/main.yaml b/roles/openshift_manageiq/tasks/main.yaml index e58947fd2..f202486a5 100644 --- a/roles/openshift_manageiq/tasks/main.yaml +++ b/roles/openshift_manageiq/tasks/main.yaml @@ -47,6 +47,9 @@ register: oshawkular_create_cluster_role failed_when: "'already exists' not in oshawkular_create_cluster_role.stderr and oshawkular_create_cluster_role.rc != 0" changed_when: oshawkular_create_cluster_role.rc == 0 + # AUDIT:changed_when_note: Checking the return code is insufficient + # here. We really need to verify the if the role even exists before + # we run this task. - name: Configure role/user permissions command: > @@ -56,6 +59,10 @@ register: osmiq_perm_task failed_when: "'already exists' not in osmiq_perm_task.stderr and osmiq_perm_task.rc != 0" changed_when: osmiq_perm_task.rc == 0 + # AUDIT:changed_when_note: Checking the return code is insufficient + # here. We really need to compare the current role/user permissions + # with their expected state. I think we may have a module for this? + - name: Configure 3_2 role/user permissions command: > |