diff options
author | OpenShift Bot <eparis+openshiftbot@redhat.com> | 2017-07-12 06:37:51 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-07-12 06:37:51 -0400 |
commit | 1da90af63656f127b21720248b5c8c25ebc728ed (patch) | |
tree | 34e1726b26d921df72583a16a1548d11973b0117 /roles/openshift_health_checker/openshift_checks | |
parent | 0d0c6d15d5d413ebefe31370a5c9ad5f0d7bada0 (diff) | |
parent | 1c213b51468fa698acb08d18ce5d6b2a5796d93d (diff) | |
download | openshift-1da90af63656f127b21720248b5c8c25ebc728ed.tar.gz openshift-1da90af63656f127b21720248b5c8c25ebc728ed.tar.bz2 openshift-1da90af63656f127b21720248b5c8c25ebc728ed.tar.xz openshift-1da90af63656f127b21720248b5c8c25ebc728ed.zip |
Merge pull request #4737 from sosiouxme/20170711-consolidate-small-prs
Merged by openshift-bot
Diffstat (limited to 'roles/openshift_health_checker/openshift_checks')
3 files changed, 5 insertions, 5 deletions
diff --git a/roles/openshift_health_checker/openshift_checks/docker_storage.py b/roles/openshift_health_checker/openshift_checks/docker_storage.py index 8d0fbcc9c..e80691ef3 100644 --- a/roles/openshift_health_checker/openshift_checks/docker_storage.py +++ b/roles/openshift_health_checker/openshift_checks/docker_storage.py @@ -17,7 +17,7 @@ class DockerStorage(DockerHostMixin, OpenShiftCheck): tags = ["pre-install", "health", "preflight"] dependencies = ["python-docker-py"] - storage_drivers = ["devicemapper", "overlay2"] + storage_drivers = ["devicemapper", "overlay", "overlay2"] max_thinpool_data_usage_percent = 90.0 max_thinpool_meta_usage_percent = 90.0 diff --git a/roles/openshift_health_checker/openshift_checks/logging/kibana.py b/roles/openshift_health_checker/openshift_checks/logging/kibana.py index 442f407b1..551e8dfa0 100644 --- a/roles/openshift_health_checker/openshift_checks/logging/kibana.py +++ b/roles/openshift_health_checker/openshift_checks/logging/kibana.py @@ -62,7 +62,7 @@ class Kibana(LoggingCheck): # TODO(lmeyer): give users option to validate certs status_code=302, ) - result = self.execute_module('uri', args, task_vars) + result = self.execute_module('uri', args, None, task_vars) if result.get('failed'): return result['msg'] return None diff --git a/roles/openshift_health_checker/openshift_checks/logging/logging.py b/roles/openshift_health_checker/openshift_checks/logging/logging.py index 05b4d300c..6e951e82c 100644 --- a/roles/openshift_health_checker/openshift_checks/logging/logging.py +++ b/roles/openshift_health_checker/openshift_checks/logging/logging.py @@ -54,12 +54,12 @@ class LoggingCheck(OpenShiftCheck): """Returns: list of pods not in a ready and running state""" return [ pod for pod in pods - if any( + if not pod.get("status", {}).get("containerStatuses") or any( container['ready'] is False for container in pod['status']['containerStatuses'] ) or not any( condition['type'] == 'Ready' and condition['status'] == 'True' - for condition in pod['status']['conditions'] + for condition in pod['status'].get('conditions', []) ) ] @@ -78,7 +78,7 @@ class LoggingCheck(OpenShiftCheck): "extra_args": list(extra_args) if extra_args else [], } - result = execute_module("ocutil", args, task_vars) + result = execute_module("ocutil", args, None, task_vars) if result.get("failed"): msg = ( 'Unexpected error using `oc` to validate the logging stack components.\n' |