diff options
author | Luke Meyer <lmeyer@redhat.com> | 2017-07-20 22:25:47 -0400 |
---|---|---|
committer | Luke Meyer <lmeyer@redhat.com> | 2017-08-02 14:06:37 -0400 |
commit | bf0828bc0f2e3088df20abc77e30a162595e1c22 (patch) | |
tree | a46617defefce2cf180666ad441451f54d418704 /roles/openshift_health_checker/openshift_checks/logging/fluentd.py | |
parent | f6e0126c3cda6622fc2371b3b603108b94ed9d39 (diff) | |
download | openshift-bf0828bc0f2e3088df20abc77e30a162595e1c22.tar.gz openshift-bf0828bc0f2e3088df20abc77e30a162595e1c22.tar.bz2 openshift-bf0828bc0f2e3088df20abc77e30a162595e1c22.tar.xz openshift-bf0828bc0f2e3088df20abc77e30a162595e1c22.zip |
openshift_checks: add property to track 'changed'
Introduced the 'changed' property for checks that can make changes to
track whether they did or not. Rather than the check's own logic having
to track this and include it in the result hash, just set the property
and have the action plugin insert it in the result hash after running
(even if there is an exception).
Cleared out a lot of crufty "changed: false" hash entries.
Diffstat (limited to 'roles/openshift_health_checker/openshift_checks/logging/fluentd.py')
-rw-r--r-- | roles/openshift_health_checker/openshift_checks/logging/fluentd.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/roles/openshift_health_checker/openshift_checks/logging/fluentd.py b/roles/openshift_health_checker/openshift_checks/logging/fluentd.py index b3485bf44..69c7b4392 100644 --- a/roles/openshift_health_checker/openshift_checks/logging/fluentd.py +++ b/roles/openshift_health_checker/openshift_checks/logging/fluentd.py @@ -20,16 +20,16 @@ class Fluentd(LoggingCheck): "fluentd", ) if error: - return {"failed": True, "changed": False, "msg": error} + return {"failed": True, "msg": error} check_error = self.check_fluentd(fluentd_pods) if check_error: msg = ("The following Fluentd deployment issue was found:" "{}".format(check_error)) - return {"failed": True, "changed": False, "msg": msg} + return {"failed": True, "msg": msg} # TODO(lmeyer): run it all again for the ops cluster - return {"failed": False, "changed": False, "msg": 'No problems found with Fluentd deployment.'} + return {"failed": False, "msg": 'No problems found with Fluentd deployment.'} @staticmethod def _filter_fluentd_labeled_nodes(nodes_by_name, node_selector): |