summaryrefslogtreecommitdiffstats
path: root/playbooks/byo/openshift-master
diff options
context:
space:
mode:
authorRussell Teague <rteague@redhat.com>2017-01-25 14:29:15 -0500
committerRussell Teague <rteague@redhat.com>2017-01-25 14:29:15 -0500
commit83ec5ce228c769fd7252600961fa5b142af00cd9 (patch)
treec94d2bad8e15e3279afe963f14312e81af194c4f /playbooks/byo/openshift-master
parentd8fee0cc8441812cdd5e7aaae815adad7a9bbee7 (diff)
downloadopenshift-83ec5ce228c769fd7252600961fa5b142af00cd9.tar.gz
openshift-83ec5ce228c769fd7252600961fa5b142af00cd9.tar.bz2
openshift-83ec5ce228c769fd7252600961fa5b142af00cd9.tar.xz
openshift-83ec5ce228c769fd7252600961fa5b142af00cd9.zip
Standardize add_host: with name and changed_when
The add_host: task does not change any data on the host and as practice has been configured to changed_when: False. This commit standardizes that usage in the byo and common playbooks. Additionally, taks names are added to each task to improve troubleshooting.
Diffstat (limited to 'playbooks/byo/openshift-master')
-rw-r--r--playbooks/byo/openshift-master/restart.yml6
-rw-r--r--playbooks/byo/openshift-master/scaleup.yml6
2 files changed, 8 insertions, 4 deletions
diff --git a/playbooks/byo/openshift-master/restart.yml b/playbooks/byo/openshift-master/restart.yml
index b60807a71..c468a898d 100644
--- a/playbooks/byo/openshift-master/restart.yml
+++ b/playbooks/byo/openshift-master/restart.yml
@@ -5,10 +5,12 @@
gather_facts: no
tasks:
- include_vars: ../../byo/openshift-cluster/cluster_hosts.yml
- - add_host:
+ - name: Evaluate group l_oo_all_hosts
+ add_host:
name: "{{ item }}"
groups: l_oo_all_hosts
- with_items: "{{ g_all_hosts }}"
+ with_items: "{{ g_all_hosts | default([]) }}"
+ changed_when: False
- hosts: l_oo_all_hosts
gather_facts: no
diff --git a/playbooks/byo/openshift-master/scaleup.yml b/playbooks/byo/openshift-master/scaleup.yml
index 279eeab21..cb9140ee2 100644
--- a/playbooks/byo/openshift-master/scaleup.yml
+++ b/playbooks/byo/openshift-master/scaleup.yml
@@ -5,10 +5,12 @@
gather_facts: no
tasks:
- include_vars: ../../byo/openshift-cluster/cluster_hosts.yml
- - add_host:
+ - name: Evaluate group l_oo_all_hosts
+ add_host:
name: "{{ item }}"
groups: l_oo_all_hosts
- with_items: "{{ g_all_hosts }}"
+ with_items: "{{ g_all_hosts | default([]) }}"
+ changed_when: False
- hosts: l_oo_all_hosts
gather_facts: no