diff options
author | Scott Dodson <sdodson@redhat.com> | 2016-12-21 13:06:27 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-12-21 13:06:27 -0500 |
commit | 4c20c6b76f295dc83e2ce730238b7753724e7e53 (patch) | |
tree | 4e6ff6855c6e5343e97d0864f47cb2088fe364f9 /filter_plugins/openshift_master.py | |
parent | 3e5f3380ccacc654450924fca830b93fda6c7592 (diff) | |
parent | 7d02b608de839cb57e2071e9d55052957c13aae3 (diff) | |
download | openshift-4c20c6b76f295dc83e2ce730238b7753724e7e53.tar.gz openshift-4c20c6b76f295dc83e2ce730238b7753724e7e53.tar.bz2 openshift-4c20c6b76f295dc83e2ce730238b7753724e7e53.tar.xz openshift-4c20c6b76f295dc83e2ce730238b7753724e7e53.zip |
Merge pull request #3001 from detiber/python3
python3 support, add tox for better local testing against multiple python versions
Diffstat (limited to 'filter_plugins/openshift_master.py')
-rw-r--r-- | filter_plugins/openshift_master.py | 22 |
1 files changed, 7 insertions, 15 deletions
diff --git a/filter_plugins/openshift_master.py b/filter_plugins/openshift_master.py index 57b1f7d82..ec09b09f6 100644 --- a/filter_plugins/openshift_master.py +++ b/filter_plugins/openshift_master.py @@ -6,22 +6,14 @@ Custom filters for use in openshift-master ''' import copy import sys -import yaml + +from distutils.version import LooseVersion # pylint: disable=no-name-in-module,import-error from ansible import errors +from ansible.plugins.filter.core import to_bool as ansible_bool +from six import string_types -# pylint: disable=no-name-in-module,import-error,wrong-import-order -from distutils.version import LooseVersion -try: - # ansible-2.1 - from ansible.plugins.filter.core import to_bool as ansible_bool -except ImportError: - try: - # ansible-2.0.x - from ansible.runner.filter_plugins.core import bool as ansible_bool - except ImportError: - # ansible-1.9.x - from ansible.plugins.filter.core import bool as ansible_bool +import yaml class IdentityProviderBase(object): @@ -513,7 +505,7 @@ class FilterModule(object): 'master3.example.com'] returns True ''' - if not issubclass(type(data), basestring): + if not issubclass(type(data), string_types): raise errors.AnsibleFilterError("|failed expects data is a string or unicode") if not issubclass(type(masters), list): raise errors.AnsibleFilterError("|failed expects masters is a list") @@ -558,7 +550,7 @@ class FilterModule(object): def oo_htpasswd_users_from_file(file_contents): ''' return a dictionary of htpasswd users from htpasswd file contents ''' htpasswd_entries = {} - if not isinstance(file_contents, basestring): + if not isinstance(file_contents, string_types): raise errors.AnsibleFilterError("failed, expects to filter on a string") for line in file_contents.splitlines(): user = None |