diff options
| author | Scott Dodson <sdodson@redhat.com> | 2017-04-28 10:47:24 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-04-28 10:47:24 -0400 |
| commit | b23be0da38759744cebc8d4b454af1299d97a445 (patch) | |
| tree | 32c3d9b18facfff34bc924347205f4981dc742c9 /docs/best_practices_guide.adoc | |
| parent | 2b420c18beae43d2f92f5a95bd177d427e81737d (diff) | |
| parent | 1d80c4cef89ce10bb71671cfffa0f35dbb28ea93 (diff) | |
| download | openshift-b23be0da38759744cebc8d4b454af1299d97a445.tar.gz openshift-b23be0da38759744cebc8d4b454af1299d97a445.tar.bz2 openshift-b23be0da38759744cebc8d4b454af1299d97a445.tar.xz openshift-b23be0da38759744cebc8d4b454af1299d97a445.zip | |
Merge pull request #3983 from rhcarvalho/docs-and-ci
Document pull request process and improve contribution guide
Diffstat (limited to 'docs/best_practices_guide.adoc')
| -rw-r--r-- | docs/best_practices_guide.adoc | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/docs/best_practices_guide.adoc b/docs/best_practices_guide.adoc index 7f3d85d40..dd849e87d 100644 --- a/docs/best_practices_guide.adoc +++ b/docs/best_practices_guide.adoc @@ -11,22 +11,6 @@ All new pull requests created against this repository MUST comply with this guid This guide complies with https://www.ietf.org/rfc/rfc2119.txt[RFC2119]. -== Pull Requests - - - -[[All-pull-requests-MUST-pass-the-build-bot-before-they-are-merged]] -[cols="2v,v"] -|=== -| <<All-pull-requests-MUST-pass-the-build-bot-before-they-are-merged, Rule>> -| All pull requests MUST pass the build bot *before* they are merged. -|=== - -The purpose of this rule is to avoid cases where the build bot will fail pull requests for code modified in a previous pull request. - -The tooling is flexible enough that exceptions can be made so that the tool the build bot is running will ignore certain areas or certain checks, but the build bot itself must pass for the pull request to be merged. - - == Python |